-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add reproduction for regression with exec + watch #10380
Conversation
Signed-off-by: Corentin Leruth <[email protected]>
35bd27b
to
3c45c0e
Compare
@@ -18,7 +18,7 @@ between each change to its code. | |||
1 | let () = print_endline "baz | |||
^ | |||
Error: String literal not terminated | |||
Had errors, waiting for filesystem changes... | |||
Had 1 error, waiting for filesystem changes... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to do with this PR, this is just a change that was never promoted
Entering directory '..' | ||
Error: posix_spawn(): No such file or directory | ||
Leaving directory '..' | ||
$ sleep 0.5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably come up with something better than sleep
, but my point was to show the problem
You can see the error in Linux on CI: https://github.com/ocaml/dune/actions/runs/8545271412/job/23413184499?pr=10380#step:11:26 |
Investigating... |
Fixed in #10386. The problem was caused by relative paths to executables in the _build directory being resolved relative to the user's cwd rather than the project root. See the the commit message of 5038bbc for more info. I've squashed your commits into a single commit with your signature attached and included it in my PR, mostly to add the tests you wrote. Thanks for the report! |
Thanks for the quick fix @gridbugs 🤗 |
This demonstrates a regression when calling the `exec' command in watch mode from a child folder of the root folder.
So in short the following works fine
But not:
In this case I get this error on Linux:
On MacOS, and according to the regression test, the error is different: