fix: regression in 11200 #11204
Merged
fix: regression in 11200 #11204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonidas-from-XIV
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Thanks for the fix! Potentially worth a changelog entry.
I suggest cherry-picking this for 3.17.1 (cc @maiste @ElectreAAS @shonfeder).
rgrinberg
force-pushed
the
ps/rr/fix__regression_in_11200
branch
from
182f704 to
ec2aa0e
Compare
Remove all error checking for empty projects in [$ dune subst] Signed-off-by: Rudi Grinberg <[email protected]> <!-- ps-id: 5a8bca2a-1764-4728-9834-590617e381e8 --> Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
force-pushed
the
ps/rr/fix__regression_in_11200
branch
from
ec2aa0e to
9e9b1f6
Compare
shonfeder
approved these changes
Dec 13, 2024
|
I'll take care of the release |
maiste
pushed a commit
to maiste/dune
that referenced
this pull request
Dec 16, 2024
Remove all error checking for empty projects in [$ dune subst] Signed-off-by: Rudi Grinberg <[email protected]>
maiste
pushed a commit
to maiste/dune
that referenced
this pull request
Dec 17, 2024
Remove all error checking for empty projects in [$ dune subst] Signed-off-by: Rudi Grinberg <[email protected]> Signed-off-by: Etienne Marais <[email protected]>
maiste
added a commit
that referenced
this pull request
Dec 17, 2024
Remove all error checking for empty projects in [$ dune subst] Signed-off-by: Rudi Grinberg <[email protected]> Signed-off-by: Etienne Marais <[email protected]> Co-authored-by: Rudi Grinberg <[email protected]>
maiste
added a commit
to maiste/opam-repository
that referenced
this pull request
Dec 17, 2024
CHANGES: ### Fixed - When a library declares `(no_dynlink)`, then the `.cmxs` file for it is no longer built. (ocaml/dune#11176, @nojb) - Fix bug that could result in corrupted file copies by Dune, for example when using the `copy_files#` stanza or the `copy#` action. (@nojb, ocaml/dune#11194, fixes ocaml/dune#11193) - Remove useless error message when running `$ dune subst` in empty projects. (@rgrinberg, ocaml/dune#11204, fixes ocaml/dune#11200)
chris-armstrong
pushed a commit
to chris-armstrong/dune
that referenced
this pull request
Jan 29, 2025
Remove all error checking for empty projects in [$ dune subst] Signed-off-by: Rudi Grinberg <[email protected]> Signed-off-by: Chris Armstrong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all error checking for empty projects in [$ dune subst]