fix(melange): use output of virtual library when compiling its source #11248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
changed the title
anmonteiro
commented
Dec 27, 2024
| @@ -597,6 +597,7 @@ let setup_js_rules_libraries = | |||
| in | |||
| cmj_includes ~requires_link ~scope lib_config | |||
| in | |||
| let output = output_of_lib ~target_dir vlib in | |||
There was a problem hiding this comment.
fix explanation: the output in scope was for output_of_lib ~target_dir lib instead of vlib.
|
ok I believe this also fixes #11247 |
Signed-off-by: Antonio Nuno Monteiro <[email protected]>
modules Signed-off-by: Antonio Nuno Monteiro <[email protected]>
Signed-off-by: Antonio Nuno Monteiro <[email protected]>
rgrinberg
approved these changes
Dec 28, 2024
anmonteiro
force-pushed
the
anmonteiro/melange-test-virtual-library-compilation-paths-public-impl
branch
from
a19b99d to
8ae566f
Compare
anmonteiro
deleted the
anmonteiro/melange-test-virtual-library-compilation-paths-public-impl
branch
anmonteiro
added a commit
to anmonteiro/dune
that referenced
this pull request
Jan 22, 2025
…ocaml#11248) * test(melange): show crash when depending on public virtual lib impl Signed-off-by: Antonio Nuno Monteiro <[email protected]> * fix(melange): use output of virtual library when compiling its source modules Signed-off-by: Antonio Nuno Monteiro <[email protected]> * chore: add changelog entry Signed-off-by: Antonio Nuno Monteiro <[email protected]> --------- Signed-off-by: Antonio Nuno Monteiro <[email protected]>
maiste
pushed a commit
that referenced
this pull request
Jan 23, 2025
…piling its source (#11371) * test(melange): show crash when depending on public virtual lib impl * fix(melange): use output of virtual library when compiling its source modules * chore: add changelog entry -------- Signed-off-by: Antonio Nuno Monteiro <[email protected]>
maiste
added a commit
to maiste/opam-repository
that referenced
this pull request
Jan 23, 2025
CHANGES: ### Fixed - Fix a crash in the Melange rules that would prevent compiling public library implementations of virtual libraries. (@amonteiro, ocaml/dune#11248) - Pass `melange.emit`'s `compile_flags` to the JS emission phase. (@amonteiro,
ElectreAAS
pushed a commit
to ElectreAAS/dune
that referenced
this pull request
Jan 27, 2025
…ocaml#11248) * test(melange): show crash when depending on public virtual lib impl Signed-off-by: Antonio Nuno Monteiro <[email protected]> * fix(melange): use output of virtual library when compiling its source modules Signed-off-by: Antonio Nuno Monteiro <[email protected]> * chore: add changelog entry Signed-off-by: Antonio Nuno Monteiro <[email protected]> --------- Signed-off-by: Antonio Nuno Monteiro <[email protected]>
chris-armstrong
pushed a commit
to chris-armstrong/dune
that referenced
this pull request
Jan 29, 2025
…ocaml#11248) * test(melange): show crash when depending on public virtual lib impl Signed-off-by: Antonio Nuno Monteiro <[email protected]> * fix(melange): use output of virtual library when compiling its source modules Signed-off-by: Antonio Nuno Monteiro <[email protected]> * chore: add changelog entry Signed-off-by: Antonio Nuno Monteiro <[email protected]> --------- Signed-off-by: Antonio Nuno Monteiro <[email protected]> Signed-off-by: Chris Armstrong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.