fix: support package pinning via http+tar #11446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne Marais <[email protected]>
Co-authored-by: ArthurW <[email protected]> Signed-off-by: Etienne Marais <[email protected]>
Signed-off-by: Etienne Marais <[email protected]>
src/dune_pkg/opamUrl0.ml
Outdated
| @@ -30,10 +30,16 @@ let is_version_control t = | |||
|
|
|||
| let is_local t = String.equal t.transport "file" | |||
|
|
|||
| let local_or_git_only url loc = | |||
| let is_tarball t = | |||
| let supported_compress_format = [ "tar.gz"; "tgz"; "tar.bz2"; "tbz" ] in | |||
There was a problem hiding this comment.
Probably should also include "tar".
Co-authored-by: Marek Kubica <[email protected]> Signed-off-by: Etienne Marais <[email protected]>
| - bar.1.0.0 | ||
| (version 1.0.0) | ||
| (dev) | ||
| (source (fetch (url http://0.0.0.0:1/tarball.tgz) (checksum md5=ecfb12cd56789e48aaa4eef289c85c40))) (dev) |
There was a problem hiding this comment.
I think it would be nice to determine the MD5 of the tarball that was created and make sure that it matches the one in the lock file. Otherwise it's not reproducible.
There was a problem hiding this comment.
I have done it using grep as the tar headers can make the hash different.
Signed-off-by: Etienne Marais <[email protected]>
Signed-off-by: Etienne Marais <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the gap between opam and dune package management functionnalities. It allows users to ping a tar file (gz or bz) using
http(andhttps) protocol.Closes #10121