Add package-level mlds to odoc include path #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
approved these changes
Apr 4, 2019
test/blackbox-tests/test-cases/odoc-package-mld-link/odoc_page_link_bug.opam
Outdated
Show resolved
Hide resolved
|
|
||
| $ dune build @doc | ||
|
|
||
| $ grep -r xref-unresolved _build/default/_doc/_html/odoc_page_link_bug/index.html |
There was a problem hiding this comment.
It might make sense of just build this target directly. It will make the tests a tad quicker.
|
Don't forget to update the change log by the way |
rgrinberg
reviewed
Apr 4, 2019
CHANGES.md
Outdated
| @@ -1,6 +1,10 @@ | |||
| unreleased | |||
| ---------- | |||
|
|
|||
| - Fix invocation of odoc to add previously missing include paths, impacting | |||
| mld files that are not in directories containing libraries (fixes #2007, | |||
| @jonludlam) | |||
There was a problem hiding this comment.
This should also include the PR number.
|
Should I rebase/force push to resolve the out-of-date issue or hit the 'update branch' button? |
|
I'm used to doing it manually. I think either one should work. |
Currently failing, this is ocaml/odoc#2007 Signed-off-by: Jon Ludlam <[email protected]>
Fixes ocaml#2007 Signed-off-by: Jon Ludlam <[email protected]>
Signed-off-by: Jon Ludlam <[email protected]>
Suggestions due to @rgrinberg Signed-off-by: Jon Ludlam <[email protected]>
Signed-off-by: Jon Ludlam <[email protected]>
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Apr 11, 2019
CHANGES: - Fix invocation of odoc to add previously missing include paths, impacting mld files that are not in directories containing libraries (ocaml/dune#2016, fixes ocaml/dune#2007, @jonludlam)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures links to/from docs that exist outside of a library are correctly resolved.