Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add support for building menhir in workspace #2365

Closed
wants to merge 1 commit into from
+17 −0
Closed

[RFC] Add support for building menhir in workspace #2365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/dune/menhir.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,12 @@ module Run (P : PARAMS) : sig end = struct
SC.resolve_program sctx ~dir "menhir" ~loc:None
~hint:"try: opam install menhir"

let local_package_dir ~sctx =
let package = Package.Name.of_string "menhir" in
let context = Context.name (Super_context.context sctx) in
let pkg = Package.Name.Map.find (Super_context.packages sctx) package in
Option.map pkg ~f:(fun _ -> Path.build (Config.local_install_lib_dir ~context ~package))

(* Reminder (from command.mli):

[Deps] is for command line arguments that are dependencies. [As] is for
Expand All @@ -112,6 +118,17 @@ module Run (P : PARAMS) : sig end = struct
(* [menhir args] generates a Menhir command line (a build action). *)

let menhir (args : 'a args) : Action.t Build.t =
let args =
match local_package_dir ~sctx with
| None ->
args
| Some path ->
let open Command.Args in
let path = Build.return path in
A "--stdlib" ::
Dyn (Build.S.map ~f:(fun x -> Path x) path) ::
Dyn (Build.S.map ~f:(fun x -> Hidden_deps (Dep.Set.of_files [Path.relative x "standard.mly"])) path) :: args
in
Command.run ~dir:(Path.build build_dir) menhir_binary args

let rule ?(mode = stanza.mode) : Action.t Build.t -> unit =
Expand Down