Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type for ctx.ccomp_type #2828

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Add type for ctx.ccomp_type #2828

merged 1 commit into from
Oct 31, 2019

Conversation

rgrinberg
Copy link
Member

This avoid the string check for msvc everywhere

@rgrinberg rgrinberg requested review from a user, nojb and emillon October 31, 2019 02:42
@rgrinberg
Add type for ctx.ccomp_type
d52d02d 
This avoid the string check for msvc everywhere

Signed-off-by: Rudi Grinberg <[email protected]>
@rgrinberg rgrinberg mentioned this pull request Oct 31, 2019
Merged
ghost
ghost approved these changes Oct 31, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rgrinberg rgrinberg merged commit 1217c92 into ocaml:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojb nojb Awaiting requested review from nojb

@emillon emillon Awaiting requested review from emillon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rgrinberg