Fix locks in rules without targets #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arseniy Alekseyev <[email protected]>
aalekseyev
changed the title
aalekseyev
force-pushed
the
locks-in-rules-without-targets
branch
from
131af55 to
dca2e3b
Compare
rgrinberg
approved these changes
Apr 15, 2020
rgrinberg
reviewed
Apr 15, 2020
src/dune/simple_rules.ml
Outdated
| @@ -124,7 +124,8 @@ let user_rule sctx ?extra_bindings ~dir ~expander (rule : Rule.t) = | |||
| let action = Some (snd rule.action) in | |||
| Alias_rules.stamp ~deps:rule.deps ~extra_bindings ~action | |||
| in | |||
| Alias_rules.add sctx ~alias ~stamp ~loc:(Some rule.loc) action; | |||
| let locks = (interpret_locks ~expander rule.locks) in | |||
There was a problem hiding this comment.
Mind running $ make fmt here?
|
optional arguments are evil |
Signed-off-by: Arseniy Alekseyev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.