Fix doc generation when several private libraries have the same name #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When several private libraries have the same name, jbuilder crashes.
|
After, we'll need to do the same for ppx rewriters |
ghost
mentioned this pull request
rgrinberg
reviewed
Dec 17, 2017
test/blackbox-tests/jbuild
Outdated
| (deps ((files_recursively_in test-cases/multiple-private-libs))) | ||
| (action | ||
| (chdir test-cases/multiple-private-libs | ||
| (setenv JBUILDER ${bin:jbuilder} (run ${exe:cram.exe} run.t)))))) |
There was a problem hiding this comment.
You might need the conditional execution trick here to make travis pass on 4.02.3
EDIT: I guess we don't run the tests against all the versions in travis. Fixing make all-supported-ocaml-versions is still worthwhile however.
rgrinberg
approved these changes
Dec 18, 2017
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When several private libraries have the same name, there is a clash for the generation of the documentation. The first commit adds a test exposing the issue.
To fix the issue, this PR assign unique names to all libraries as follow:
<name>@<scope-name>The scope name is the shortest package name in the current scope, or the empty string for the global scope.