Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce %{lib-private} bug #3777

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

rgrinberg
Copy link
Member

The setup is as follows:

  • We 2 packages in a single project
  • 1 package uses %{lib-private} to refer to the artifacts of the other
    package
  • This works in development builds
  • It fails in production because -p (and --only-packages) hide the
    definition of the 1st package

Signed-off-by: Rudi Grinberg [email protected]

@snowleopard this is the bug I had in mind in slack.

The setup is as follows:
* We 2 packages in a single project
* 1 package uses %{lib-private} to refer to the artifacts of the other
package
* This works in development builds
* It fails in production because -p (and --only-packages) hide the
definition of the 1st package

Signed-off-by: Rudi Grinberg <[email protected]>
@rgrinberg
Copy link
Member Author

It should be possible to fix this issue once I wrap up #3655

I ran into the same problem there and developed a mechanism to address this issue.

Copy link
Collaborator

@snowleopard snowleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, looks like a bug. Thanks for the test case!

@snowleopard snowleopard merged commit 4306700 into ocaml:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants