Report better errors for globs pointing to non-existing directories #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
approved these changes
Jan 15, 2018
| | None -> | ||
| Loc.warn loc "Directory %s doesn't exist." | ||
| (Path.to_string_maybe_quoted dir); | ||
| state := G_evaluated []; |
There was a problem hiding this comment.
Did this mean that the non-existent glob would be executed more than once? So it's a bit more than just better error reporting?
There was a problem hiding this comment.
It's not documented, but static_deps is assumed to turn all the Paths_glob from G_unevaluated to G_evaluated. It wasn't done in this branch and it was a mistake
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #412