[cram] Add locks to the Cram stanza #4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
approved these changes
Mar 25, 2021
|
One remark: locks are filenames and a cram stanza apply to a whole subtree. So it's important that the lock names are interpreted relative to where the cram stanza is written rather than where the .t file happens to be. Might be worth adding a test with a single cram stanza and cram tests at different depth in the tree, to verify that they all take the same lock. |
Well spotted: if I move one of the two tests that should share the same lock in a subdirectory they don(t run sequentially. |
ghost
reviewed
Mar 30, 2021
voodoos
force-pushed
the
cram-locks
branch
2 times, most recently
from
9349675 to
9a3742a
Compare
|
@rgrinberg I changed the implementation to have locks always relative to the cram stanza , it should be worth it to review it again. |
rgrinberg
reviewed
Apr 3, 2021
rgrinberg
reviewed
Apr 3, 2021
rgrinberg
approved these changes
Apr 6, 2021
Signed-off-by: Ulysse Gérard <[email protected]>
Signed-off-by: Ulysse Gérard <[email protected]>
Signed-off-by: Ulysse Gérard <[email protected]>
Signed-off-by: Ulysse Gérard <[email protected]>
voodoos
added a commit
to voodoos/dune
that referenced
this pull request
Apr 12, 2021
* Add locks to Cram stanza * Add timing-based tests for the locks * Reference the new option in the docs * Add changelog entry Signed-off-by: Ulysse Gérard <[email protected]>
voodoos
added a commit
to voodoos/dune
that referenced
this pull request
Apr 12, 2021
* Add locks to Cram stanza * Add timing-based tests for the locks * Reference the new option in the docs * Add changelog entry Signed-off-by: Ulysse Gérard <[email protected]>
voodoos
added a commit
to voodoos/dune
that referenced
this pull request
Apr 12, 2021
* Add locks to Cram stanza * Add timing-based tests for the locks * Reference the new option in the docs * Add changelog entry Signed-off-by: Ulysse Gérard <[email protected]>
voodoos
added a commit
to voodoos/dune
that referenced
this pull request
Apr 14, 2021
* Add locks to Cram stanza * Add timing-based tests for the locks * Reference the new option in the docs * Add changelog entry Signed-off-by: Ulysse Gérard <[email protected]>
voodoos
added a commit
to voodoos/dune
that referenced
this pull request
Jun 4, 2021
* Add locks to Cram stanza * Add timing-based tests for the locks * Reference the new option in the docs * Add changelog entry Signed-off-by: Ulysse Gérard <[email protected]>
ejgallego
added a commit
that referenced
this pull request
Jun 7, 2021
* Add locks to Cram stanza * Add timing-based tests for the locks * Reference the new option in the docs * Add changelog entry Signed-off-by: Ulysse Gérard <[email protected]> Co-authored-by: Emilio Jesús Gallego Arias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds locks to the Cram stanza. This is necessary to run some mutually exclusive tests.
For example we have some tests of the Merlin server that fail randomly when executed concurrently.
Of course the hard part is testing these changes:
INSIDE_DUNEbut I believe this should not be too dangerous if I then always specify the--rootof the workspace on the command line ?