Add a configuration file and a quiet mode #490
Conversation
| fiber) | ||
| (Fiber.fork_and_join_unit | ||
| (fun () -> go_rec t) | ||
| (fun () -> fiber)) |
There was a problem hiding this comment.
Previously, this change was simply omitted, right? I assume this is just for perf.
There was a problem hiding this comment.
Yes, it was a mistake. This showed up after this patch as sometimes the status line wasn't cleaned up at the end
| include Jbuilder.Scheduler | ||
|
|
||
| let go ?log ~common fiber = | ||
| Scheduler.go ?log ~config:common.config fiber |
There was a problem hiding this comment.
I wonder if we should just initialize the log here from ~common. I think that's what we always do anywhere.
There was a problem hiding this comment.
indeed, although I think there is a case where we call the scheduler twice
|
Also it would be nice to enumerate the display options in |
Indeed. We could also allow to customize the status line: (status_line "foo: ${todo}, jobs: ${jobs}")One things I'm going to add straight after that is: (jobs 20)
indeed |
|
I added the doc. I was finding that the man page was getting big, so I added |
ghost
merged commit 
ghost
mentioned this pull request
Once we don't stop at the first error, the output becomes messy. This PR adds display modes:
quiet: only print errorsprogress: interactive display showing the number of rules processed so far and the number of parallel jobs running. This is the new defaultshort: current defaultverbose: same as current--verboseThe display mode can be selected via the
--displaycommand line argument, or via the configuration file~/.config/dune/config.TODO: