[2.9] Compatibility with OCaml 5.0 #5351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not use deprecated Format functions Signed-off-by: Rudi Grinberg <[email protected]> ps-id: 7DBD82E0-2A3C-4C2C-AE1D-3A0FFE042BD6
It used to rely on the deprecated tag API, which is going away in 5.0. Using this patch, `make dune.exe` works with the current trunk (310541fe74dddcf05c17ae3f9d4feaace4a57287). Signed-off-by: Etienne Millon <[email protected]>
Signed-off-by: Etienne Millon <[email protected]>
ejgallego
approved these changes
Jan 20, 2022
kit-ty-kate
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Jan 23, 2022
CHANGES: - Fix missing -linkall flag when linking library dune-sites.plugin ( ocaml/dune#4348, @Kakadu, @bobot, reported by @Kakadu) - No longer reference deprecated Toploop functions when using dune files in OCaml syntax. (ocaml/dune#4834, fixes ocaml/dune#4830, @nojb) - Use the stag format API to be compatible with OCaml 5.0 (ocaml/dune#5351, @emillon). - Fix post-processing of dune-package (fix ocaml/dune#4389, @strub)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists in 2 cherry-picked commits about compatibility with current trunk, related to the format API.