fix: wait until output if flushed #6119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might also fix the issue I observed where the LSP server being reset whilst Dune was building in watch mode caused Dune to silently crash. |
|
@esope could you check if it fixes the error? |
|
Yes, it fixes the error. Thanks! |
emillon
approved these changes
Sep 6, 2022
rgrinberg
force-pushed
the
ps/rr/fix__wait_until_output_if_flushed
branch
from
8134b39 to
36027c4
Compare
Alizter
approved these changes
Sep 7, 2022
wait until all output is flushed before terminating dune Signed-off-by: Rudi Grinberg <[email protected]> ps-id: 4a999aa6-1018-4ec0-a3b2-8f54426e4885
rgrinberg
force-pushed
the
ps/rr/fix__wait_until_output_if_flushed
branch
from
36027c4 to
1bd88f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait until all output is flushed before terminating dune
Signed-off-by: Rudi Grinberg [email protected]
ps-id: 4a999aa6-1018-4ec0-a3b2-8f54426e4885