Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move jsoo rules to jsoo dir #6861

Merged

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Jan 9, 2023

Should this be js_of_ocaml instead?

Signed-off-by: Ali Caglayan [email protected]

@Alizter Alizter requested a review from rgrinberg January 10, 2023 00:05
@rgrinberg
Copy link
Member

I'll wait until the all the wip jsoo PR's are merging this.

@hhugo
Copy link
Collaborator

hhugo commented Jan 10, 2023

(There is currently only #6832 in the pipe for jsoo, just waiting for review)

Signed-off-by: Ali Caglayan <[email protected]>

<!-- ps-id: 1d8e480e-5e6a-4843-ad9d-96b14df6bfa9 -->
@Alizter Alizter force-pushed the ps/rr/chore__move_jsoo_rules_to_jsoo_dir branch from 46d3575 to 7c9c94c Compare January 12, 2023 21:55
@rgrinberg rgrinberg merged commit 73a3b3b into ocaml:main Jan 17, 2023
@hhugo
Copy link
Collaborator

hhugo commented Jan 17, 2023

I've rebased #6832 on top of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants