Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all_lib_deps_by_context doesn't report invalid contexts #723

Merged
1 commit merged into from Apr 25, 2018
Merged

Make sure all_lib_deps_by_context doesn't report invalid contexts #723

1 commit merged into from Apr 25, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 25, 2018

This fixes a bug reported by @samoht on slack

@ghost ghost requested a review from rgrinberg April 25, 2018 12:22
@samoht
Copy link
Member

samoht commented Apr 25, 2018

That seems to work for me:

$ jbuilder external-lib-deps --missing --dev @runtest
File "bin/main.ml", line 766, characters 28-34: Assertion failed
Backtrace:
Raised at file "bin/main.ml", line 766, characters 28-40
Called from file "map.ml", line 315, characters 19-42
Called from file "map.ml", line 315, characters 26-41
Called from file "bin/main.ml", line 760, characters 9-1023
Called from file "src/fiber/fiber.ml", line 359, characters 6-13

$ opam pin add jbuilder [email protected]:ocaml/dune.git#pull/723/head -y
$ jbuilder external-lib-deps --missing --dev @runtest
$ 

@ghost ghost merged commit 2af69cb into ocaml:master Apr 25, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants