Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix macOS test suite #7236

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

anmonteiro
Copy link
Collaborator

Signed-off-by: Antonio Nuno Monteiro <[email protected]>
@Alizter
Copy link
Collaborator

Alizter commented Mar 7, 2023

Why not just disable on macos? Do we expect different behaviour because of the platform?

@anmonteiro
Copy link
Collaborator Author

anmonteiro commented Mar 7, 2023

The behavior is the same, but macOS additionally prints an "abort trap: 6" message.

This change makes the test reproducible. my impression was that's favored over disabling entirely, e.g. #7174

@rgrinberg rgrinberg merged commit 16b7df3 into ocaml:main Mar 8, 2023
@anmonteiro anmonteiro deleted the anmonteiro/macos-tests branch March 8, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants