-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .dune-fs
files
#750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good, but I'd add some blackbox tests for this feature as well (and jbuild-ignore as well)
indeed, i'll add tests. Thinking about this again, i don't know why not just use a |
I tried that. I still need to update the documentation, but I think it's better this way |
Jérémie Dimino <[email protected]> writes:
I tried that. I still need to update the documentation, but I think it's better this way
+1 - one less file.
|
Indeed. BTW while adding the test, I realised that there is something a bit odd: you can use a In the end, I'm wondering if we shouldn't have only |
Superseded by #767 |
To replace
jbuild-ignore
files