Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .dune-fs files #750

Closed
wants to merge 11 commits into from
Closed

Add support for .dune-fs files #750

wants to merge 11 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 8, 2018

To replace jbuild-ignore files

@ghost ghost requested a review from rgrinberg May 8, 2018 15:32
Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, but I'd add some blackbox tests for this feature as well (and jbuild-ignore as well)

@ghost
Copy link
Author

ghost commented May 10, 2018

indeed, i'll add tests.

Thinking about this again, i don't know why not just use a fs stanza in dune files. That would get rid of one kind of files

@ghost
Copy link
Author

ghost commented May 10, 2018

I tried that. I still need to update the documentation, but I think it's better this way

@ghost ghost mentioned this pull request May 10, 2018
@rgrinberg
Copy link
Member

rgrinberg commented May 11, 2018 via email

@ghost
Copy link
Author

ghost commented May 11, 2018

Indeed. BTW while adding the test, I realised that there is something a bit odd: you can use a fs stanza to ignore for instance *.x. But this setting is not sticky. In particular, when marking a sub-tree as raw_data, then the default settings are assumed inside this sub-tree. This limitation is a bit odd, and we might end up having to extend this feature in the future.

In the end, I'm wondering if we shouldn't have only (ignored_subdirs (a b c)) for now. Since #732, all pending fs issues have been solved and there have been no request for something more advanced than ignoring sub-trees.

@ghost ghost mentioned this pull request May 11, 2018
@ghost
Copy link
Author

ghost commented May 11, 2018

Superseded by #767

@ghost ghost closed this May 11, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants