Add (explain) field to (menhir) stanza #9512

nojb · 2023-12-15T08:46:50Z

A simple-minded attempt at resolving #6865: add an (explain) field to the (menhir) stanza.

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

gasche · 2023-12-15T08:55:18Z

Nice!

It would be nice to also update the documentation.

Would there be a way for users to access the .conflicts file that does not involve foraging into the build artifact directory? (For example, is it the case that dune exec -- less foo/Parser.conflicts would work?)

nojb · 2023-12-15T09:08:53Z

It would be nice to also update the documentation.

Yes, will do.

For example, is it the case that dune exec -- less foo/Parser.conflicts would work?

This seems to work.

Would there be a way for users to access the .conflicts file that does not involve foraging into the build artifact directory?

One can also add (mode (promote (until-clean))) in the (menhir) stanza to "promote" the .conflicts file to the current directory, but this will also promote the generated .ml/.mli files (Dune does not appear to be able to promote only a subset of the generated files by a rule at the moment).

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb · 2023-12-15T09:21:35Z

I pushed another commit 0b46891 detecting the --explain flag in the (flags) field. I'm in two minds whether this one is better than (explain).

gasche · 2023-12-15T09:32:15Z

I don't like the idea of seeing the generated .ml and .mli in my build directory. For the time being I would rather document dune exec -- less.

gasche · 2023-12-15T09:35:37Z

I wonder whether explain should be the default. This sounds like a very convenient thing to have, and I don't see any immediate cost -- presumably this has a performance cost, but this is neglectible for not-too-large grammars.

Does your current implementation support (explain false) to disable the option (should be a no-op for now)? Having this working today would be convenient if (explain) becomes the default now or in the future.

cc @fpottier: do you see an obvious issue with Dune passing --explain by default to Menhir? (Are there realistic use-cases where this is problematic?)

ejgallego · 2023-12-15T09:42:38Z

Explain being the default would make sense, note however the case where the user does something like (flags :standard \ --explain) should be either documented as not supported, or supported.

For the Coq mode, understanding flags would have been very convenient, but there were too many corner cases in the end.

This reverts commit 0b46891. Signed-off-by: Nicolás Ojeda Bär <[email protected]>

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb · 2023-12-15T12:58:24Z

I wonder whether explain should be the default. This sounds like a very convenient thing to have, and I don't see any immediate cost -- presumably this has a performance cost, but this is neglectible for not-too-large grammars.

I think this makes sense; I switched the default (but we can switch back if there are good reasons to do so).

Does your current implementation support (explain false) to disable the option (should be a no-op for now)? Having this working today would be convenient if (explain) becomes the default now or in the future.

This is now supported.

understanding flags would have been very convenient, but there were too many corner cases in the end.

I reverted the auto-detection of the --explain flag; too many corner cases and the explicit (explain <bool>) (especially if the default is true) seems simpler and clearer.

rgrinberg · 2023-12-15T20:34:15Z

Dune does not appear to be able to promote only a subset of the generated files by a rule at the moment

There's actually (promote (only ..)). Although I don't know whether it's good to use this in the end. Also, I guess it can't be combined with until-clean?

Would there be a way for users to access the .conflicts file that does not involve foraging into the build artifact directory? (For example, is it the case that dune exec -- less foo/Parser.conflicts would work?)

We can also add a specialized dune subcommand for menhir. I don't know if using dune exec is all that obvious.

A couple of improvements I would like to suggest:

We should add a warning or error if the user passes --explain manually and point them to this feature (only when the newer version is enabled)
We should allow blang expressions inside (explain ..) to allow conditionally enabling this feature. It can always be added later, but it creates complications due to versioning.

rgrinberg · 2023-12-15T20:35:17Z

src/dune_rules/menhir/menhir_stanza.ml

-     { merge_into; flags; modules; mode; loc; infer; enabled_if })
+     let explain =
+       match explain with
+       | None -> dune_syntax >= (3, 13)


I think you should use the version of the menhir syntax to control this behavior.

Good point, done.

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb · 2023-12-15T21:06:43Z

2. We should allow blang expressions inside (explain ..) to allow conditionally enabling this feature. It can always be added later, but it creates complications due to versioning.

This should now be working.

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb · 2023-12-15T21:23:01Z

We should add a warning or error if the user passes --explain manually and point them to this feature (only when the newer version is enabled)

I pushed something along these lines, let me know if it looks OK.

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb · 2023-12-15T21:26:38Z

@rgrinberg just to confirm before this gets merged: do you think it is OK to switch the default to generate the .conflicts file?

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb · 2023-12-16T13:57:14Z

I pushed one more commit that:

Adds a new (menhir (flags ...) (explain ...)) field to the (env) stanza allowing to set the new (explain) setting using (env) as well.
Removes the old (menhir_flags ...) field of (env) (as it is replaced by (menhir (flags ...))).

The CRAM test shows these features in action.

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

Alizter · 2023-12-16T14:22:31Z

@nojb could you test that this works with a dune-workspace file?

rgrinberg · 2023-12-16T15:36:38Z

There's no need for such a test, there's already one that demonstrates the menhir flags cannot be set in the workspace file.

src/dune_lang/blang.ml

rgrinberg · 2023-12-16T15:45:32Z

I pushed one more commit that:

Adds a new (menhir (flags ...) (explain ...)) field to the (env) stanza allowing to set the new (explain) setting using (env) as well.

Removes the old (menhir_flags ...) field of (env) (as it is replaced by (menhir (flags ...))).

The CRAM test shows these features in action.

The addition looks good. Given that the new version of the menhir syntax isn't strictly backward compatible, how about bumping it to (3, 0)?

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb · 2023-12-16T21:23:23Z

The addition looks good. Given that the new version of the menhir syntax isn't strictly backward compatible, how about bumping it to (3, 0)?

Done, thanks.

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb · 2023-12-16T21:29:37Z

(This is ready from my side.)

rgrinberg · 2023-12-16T22:23:14Z

This is ready from my end as well.

rgrinberg · 2023-12-17T03:45:21Z

Will take the liberty to merge this one to avoid a merge conflict with some of my own work. Thanks @nojb!

nojb · 2023-12-17T09:14:10Z

Thanks!

gasche · 2023-12-17T20:30:54Z

Thanks as well!

@rgrinberg

CHANGES: - Do not ignore `(formatting ..)` settings in context or workspace files (ocaml/dune#8447, @rgrinberg) - Add command `dune cache clear` to completely delete all traces of the Dune cache. (ocaml/dune#8975, @nojb) - Fixed a bug where Dune was incorrectly parsing the output of coqdep when it was escaped, as is the case on Windows. (ocaml/dune#9231, fixes ocaml/dune#9218, @Alizter) - Copying mode for sandboxes will now follow symbolic links (ocaml/dune#9282, @rgrinberg) - Forbid the empty `(binaries ..)` field in the `env` stanza in the workspace file unless language version is at least 3.2. - [coq] Fix bug in computation of flags when composed with boot theories. (ocaml/dune#9347, fixes ocaml/dune#7909, @ejgallego) - Fixed a bug where the `(select)` field of the `(libraries)` field of the `(test)` stanza wasn't working properly. (ocaml/dune#9387, fixes ocaml/dune#9365, @Alizter) - Allow to disable Coq 0.8 deprecation warning (ocaml/dune#9439, @ejgallego) - Fix handling of the `PATH` argument to `dune init proj NAME PATH`. An intermediate directory called `NAME` is no longer created if `PATH` is supplied, so `dune init proj my_project .` will now initialize a project in the current working directory. (ocaml/dune#9447, fixes ocaml/dune#9209, @shonfeder) - Allow `OCAMLFIND_TOOLCHAIN` to be set per context in the workspace file through the `env` stanza. (ocaml/dune#9449, @rgrinberg) - Experimental doc rules: Correctly handle the case when a package depends upon its own sublibraries (ocaml/dune#9461, fixes ocaml/dune#9456, @jonludlam) - Resolve various public binaries to their build location, rather than to where they're copied in the `_build/install` directory (ocaml/dune#9496, fixes ocaml/dune#7908, @rgrinberg). - Menhir: generate `.conflicts` file by default. Add new field to the `(menhir)` stanza to control the generation of this file: `(explain <blang expression>)`. Introduce `(menhir (flags ...) (explain ...))` field in the `(env)` stanza, delete `(menhir_flags)` field. All changes are guarded under a new version of the Menhir extension, 3.0. (ocaml/dune#9512, @nojb) - Correctly ignore warning flags in vendored projects (ocaml/dune#9515, @rgrinberg) - Directory targets can now be caches. (ocaml/dune#9535, @rleshchinskiy) - Remove warning 30 from default set for projects where dune lang is at least 3.13 (ocaml/dune#9568, @gasche) - It is now possible to use special forms such as `(:include)` and variables `%{read-lines:}` in `(modules)` and similar fields. Note that the dependencies introduced in this way (ie the files being read) must live in a different directory than the stanza making use of them. (ocaml/dune#9578, @nojb) - Use watch exclusions in watch mode on MacOS (ocaml/dune#9643, fixes ocaml/dune#9517, @PoorlyDefinedBehaviour) - Fix merlin configuration for `(include_subdirs qualified)` modules (ocaml/dune#9659, fixes ocaml/dune#8297, @rgrinberg) - Fix handling of `enabled_if` in binary install stanzas. Previously, we'd ignore the result of `enabled_if` when evaluating `%{bin:..}` (ocaml/dune#9707, @rgrinberg) - Add `coqdoc_flags` field to `coq` field of `env` stanza allowing the setting of workspace-wide defaults for `coqdoc_flags`. (ocaml/dune#9280, fixes ocaml/dune#9139, @Alizter) - ctypes: fix an error where `(ctypes)` with no `(function_description)` would cause an error trying refer to a nonexistent `_stubs.a` dependency (ocaml/dune#9302, fix ocaml/dune#9300, @emillon)

@nojb

CHANGES: ### Added - Add command `dune cache clear` to completely delete all traces of the Dune cache. (ocaml/dune#8975, @nojb) - Allow to disable Coq 0.8 deprecation warning (ocaml/dune#9439, @ejgallego) - Allow `OCAMLFIND_TOOLCHAIN` to be set per context in the workspace file through the `env` stanza. (ocaml/dune#9449, @rgrinberg) - Menhir: generate `.conflicts` file by default. Add new field to the `(menhir)` stanza to control the generation of this file: `(explain <blang expression>)`. Introduce `(menhir (flags ...) (explain ...))` field in the `(env)` stanza, delete `(menhir_flags)` field. All changes are guarded under a new version of the Menhir extension, 3.0. (ocaml/dune#9512, @nojb) - Directory targets can now be cached. (ocaml/dune#9535, @rleshchinskiy) - It is now possible to use special forms such as `(:include)` and variables `%{read-lines:}` in `(modules)` and similar fields. Note that the dependencies introduced in this way (ie the files being read) must live in a different directory than the stanza making use of them. (ocaml/dune#9578, @nojb) - Remove warning 30 from default set for projects where dune lang is at least 3.13 (ocaml/dune#9568, @gasche) - Add `coqdoc_flags` field to `coq` field of `env` stanza allowing the setting of workspace-wide defaults for `coqdoc_flags`. (ocaml/dune#9280, fixes ocaml/dune#9139, @Alizter) - ctypes: fix an error where `(ctypes)` with no `(function_description)` would cause an error trying refer to a nonexistent `_stubs.a` dependency (ocaml/dune#9302, fix ocaml/dune#9300, @emillon) ### Changed - Check that package names in `(depends)` and related fields in `dune-project` are well-formed. (ocaml/dune#9472, fixes ocaml/dune#9270, @ElectreAAS) ### Fixed - Do not ignore `(formatting ..)` settings in context or workspace files (ocaml/dune#8447, @rgrinberg) - Fixed a bug where Dune was incorrectly parsing the output of coqdep when it was escaped, as is the case on Windows. (ocaml/dune#9231, fixes ocaml/dune#9218, @Alizter) - Copying mode for sandboxes will now follow symbolic links (ocaml/dune#9282, @rgrinberg) - Forbid the empty `(binaries ..)` field in the `env` stanza in the workspace file unless language version is at least 3.2. - [coq] Fix bug in computation of flags when composed with boot theories. (ocaml/dune#9347, fixes ocaml/dune#7909, @ejgallego) - Fixed a bug where the `(select)` field of the `(libraries)` field of the `(test)` stanza wasn't working properly. (ocaml/dune#9387, fixes ocaml/dune#9365, @Alizter) - Fix handling of the `PATH` argument to `dune init proj NAME PATH`. An intermediate directory called `NAME` is no longer created if `PATH` is supplied, so `dune init proj my_project .` will now initialize a project in the current working directory. (ocaml/dune#9447, fixes ocaml/dune#9209, @shonfeder) - Experimental doc rules: Correctly handle the case when a package depends upon its own sublibraries (ocaml/dune#9461, fixes ocaml/dune#9456, @jonludlam) - Resolve various public binaries to their build location, rather than to where they're copied in the `_build/install` directory (ocaml/dune#9496, fixes ocaml/dune#7908, @rgrinberg). - Correctly ignore warning flags in vendored projects (ocaml/dune#9515, @rgrinberg) - Use watch exclusions in watch mode on MacOS (ocaml/dune#9643, fixes ocaml/dune#9517, @PoorlyDefinedBehaviour) - Fix merlin configuration for `(include_subdirs qualified)` modules (ocaml/dune#9659, fixes ocaml/dune#8297, @rgrinberg) - Fix handling of `enabled_if` in binary install stanzas. Previously, we'd ignore the result of `enabled_if` when evaluating `%{bin:..}` (ocaml/dune#9707, @rgrinberg)

@nojb

CHANGES: ### Added - Add command `dune cache clear` to completely delete all traces of the Dune cache. (ocaml/dune#8975, @nojb) - Allow to disable Coq 0.8 deprecation warning (ocaml/dune#9439, @ejgallego) - Allow `OCAMLFIND_TOOLCHAIN` to be set per context in the workspace file through the `env` stanza. (ocaml/dune#9449, @rgrinberg) - Menhir: generate `.conflicts` file by default. Add new field to the `(menhir)` stanza to control the generation of this file: `(explain <blang expression>)`. Introduce `(menhir (flags ...) (explain ...))` field in the `(env)` stanza, delete `(menhir_flags)` field. All changes are guarded under a new version of the Menhir extension, 3.0. (ocaml/dune#9512, @nojb) - Directory targets can now be cached. (ocaml/dune#9535, @rleshchinskiy) - It is now possible to use special forms such as `(:include)` and variables `%{read-lines:}` in `(modules)` and similar fields. Note that the dependencies introduced in this way (ie the files being read) must live in a different directory than the stanza making use of them. (ocaml/dune#9578, @nojb) - Remove warning 30 from default set for projects where dune lang is at least 3.13 (ocaml/dune#9568, @gasche) - Add `coqdoc_flags` field to `coq` field of `env` stanza allowing the setting of workspace-wide defaults for `coqdoc_flags`. (ocaml/dune#9280, fixes ocaml/dune#9139, @Alizter) - ctypes: fix an error where `(ctypes)` with no `(function_description)` would cause an error trying refer to a nonexistent `_stubs.a` dependency (ocaml/dune#9302, fix ocaml/dune#9300, @emillon) ### Changed - Check that package names in `(depends)` and related fields in `dune-project` are well-formed. (ocaml/dune#9472, fixes ocaml/dune#9270, @ElectreAAS) ### Fixed - Do not ignore `(formatting ..)` settings in context or workspace files (ocaml/dune#8447, @rgrinberg) - Fixed a bug where Dune was incorrectly parsing the output of coqdep when it was escaped, as is the case on Windows. (ocaml/dune#9231, fixes ocaml/dune#9218, @Alizter) - Copying mode for sandboxes will now follow symbolic links (ocaml/dune#9282, @rgrinberg) - Forbid the empty `(binaries ..)` field in the `env` stanza in the workspace file unless language version is at least 3.2. - [coq] Fix bug in computation of flags when composed with boot theories. (ocaml/dune#9347, fixes ocaml/dune#7909, @ejgallego) - Fixed a bug where the `(select)` field of the `(libraries)` field of the `(test)` stanza wasn't working properly. (ocaml/dune#9387, fixes ocaml/dune#9365, @Alizter) - Fix handling of the `PATH` argument to `dune init proj NAME PATH`. An intermediate directory called `NAME` is no longer created if `PATH` is supplied, so `dune init proj my_project .` will now initialize a project in the current working directory. (ocaml/dune#9447, fixes ocaml/dune#9209, @shonfeder) - Experimental doc rules: Correctly handle the case when a package depends upon its own sublibraries (ocaml/dune#9461, fixes ocaml/dune#9456, @jonludlam) - Resolve various public binaries to their build location, rather than to where they're copied in the `_build/install` directory (ocaml/dune#9496, fixes ocaml/dune#7908, @rgrinberg). - Correctly ignore warning flags in vendored projects (ocaml/dune#9515, @rgrinberg) - Use watch exclusions in watch mode on MacOS (ocaml/dune#9643, fixes ocaml/dune#9517, @PoorlyDefinedBehaviour) - Fix merlin configuration for `(include_subdirs qualified)` modules (ocaml/dune#9659, fixes ocaml/dune#8297, @rgrinberg) - Fix handling of `enabled_if` in binary install stanzas. Previously, we'd ignore the result of `enabled_if` when evaluating `%{bin:..}` (ocaml/dune#9707, @rgrinberg)

Add (explain) field to (menhir) stanza

4bd8fd2

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb mentioned this pull request Dec 15, 2023

Using menhir --explain #6865

Closed

nojb added 2 commits December 15, 2023 10:19

Doc

028cabc

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

Also detect --menhir flag

0b46891

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb added 3 commits December 15, 2023 13:33

Revert "Also detect --menhir flag"

72de97e

This reverts commit 0b46891. Signed-off-by: Nicolás Ojeda Bär <[email protected]>

Switch to (explain <bool>)

2626c7a

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

Generate file by default

4a32150

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

rgrinberg added the menhir label Dec 15, 2023

rgrinberg reviewed Dec 15, 2023

View reviewed changes

nojb added 2 commits December 15, 2023 21:43

Control the default with the version of the Menhir extension

922c580

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

Allow (explain <blang>)

045407f

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

rgrinberg approved these changes Dec 15, 2023

View reviewed changes

Doc

3c42b01

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

Merge branch 'main' into menhir_explain

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

2f8afb1

rgrinberg added this to the 3.13.0 milestone Dec 15, 2023

Warn if passing --explain under the new mode

560a1a9

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

Changes

683c645

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb added 2 commits December 15, 2023 22:28

Cleanup

571412f

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

Less verbose tests

67f006e

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb force-pushed the menhir_explain branch 2 times, most recently from e1090b1 to f28c50e Compare December 16, 2023 13:57

Introduce (menhir) field in (env) stanza

4aafa94

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb force-pushed the menhir_explain branch from f28c50e to 4aafa94 Compare December 16, 2023 14:07

rgrinberg reviewed Dec 16, 2023

View reviewed changes

src/dune_lang/blang.ml Outdated Show resolved Hide resolved

nojb added 3 commits December 16, 2023 22:15

Use List.equal

d8127be

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

Bump Menhir extension version to 3.0

50ec8da

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

Accept tests

ee94d7f

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

nojb added 2 commits December 16, 2023 22:23

Merge branch 'main' into menhir_explain

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

1468c5e

Fix Doc

Loading
Loading status checks…

0546401

Signed-off-by: Nicolás Ojeda Bär <[email protected]>

rgrinberg merged commit 5088f61 into ocaml:main Dec 17, 2023

rgrinberg mentioned this pull request Dec 17, 2023

fix: keep menhir .conflicts files (#6865) #9025

Closed

nojb deleted the menhir_explain branch December 17, 2023 09:14

emillon mentioned this pull request Jan 12, 2024

[new release] dune (15 packages) (3.13.0~alpha1) ocaml/opam-repository#25067

Closed

emillon mentioned this pull request Jan 16, 2024

[new release] dune (15 packages) (3.13.0) ocaml/opam-repository#25081

Merged

This was referenced Dec 10, 2024

Use menhir 3.0 kuis-isle3sw/IoPLMaterials#112

Merged

dune: update menhir extension to 3.0 ocsigen/js_of_ocaml#1766

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add (explain) field to (menhir) stanza #9512

Add (explain) field to (menhir) stanza #9512

nojb commented Dec 15, 2023 •

edited

Loading

gasche commented Dec 15, 2023

nojb commented Dec 15, 2023 •

edited

Loading

nojb commented Dec 15, 2023

gasche commented Dec 15, 2023

gasche commented Dec 15, 2023 •

edited

Loading

ejgallego commented Dec 15, 2023

nojb commented Dec 15, 2023

rgrinberg commented Dec 15, 2023

rgrinberg Dec 15, 2023

nojb Dec 15, 2023

nojb commented Dec 15, 2023 •

edited

Loading

nojb commented Dec 15, 2023 •

edited

Loading

nojb commented Dec 15, 2023 •

edited

Loading

nojb commented Dec 16, 2023 •

edited

Loading

Alizter commented Dec 16, 2023

rgrinberg commented Dec 16, 2023

rgrinberg commented Dec 16, 2023

nojb commented Dec 16, 2023

nojb commented Dec 16, 2023

rgrinberg commented Dec 16, 2023

rgrinberg commented Dec 17, 2023

nojb commented Dec 17, 2023

gasche commented Dec 17, 2023

Add (explain) field to (menhir) stanza #9512

Add (explain) field to (menhir) stanza #9512

Conversation

nojb commented Dec 15, 2023 • edited Loading

gasche commented Dec 15, 2023

nojb commented Dec 15, 2023 • edited Loading

nojb commented Dec 15, 2023

gasche commented Dec 15, 2023

gasche commented Dec 15, 2023 • edited Loading

ejgallego commented Dec 15, 2023

nojb commented Dec 15, 2023

rgrinberg commented Dec 15, 2023

rgrinberg Dec 15, 2023

Choose a reason for hiding this comment

nojb Dec 15, 2023

Choose a reason for hiding this comment

nojb commented Dec 15, 2023 • edited Loading

nojb commented Dec 15, 2023 • edited Loading

nojb commented Dec 15, 2023 • edited Loading

nojb commented Dec 16, 2023 • edited Loading

Alizter commented Dec 16, 2023

rgrinberg commented Dec 16, 2023

rgrinberg commented Dec 16, 2023

nojb commented Dec 16, 2023

nojb commented Dec 16, 2023

rgrinberg commented Dec 16, 2023

rgrinberg commented Dec 17, 2023

nojb commented Dec 17, 2023

gasche commented Dec 17, 2023

nojb commented Dec 15, 2023 •

edited

Loading

nojb commented Dec 15, 2023 •

edited

Loading

gasche commented Dec 15, 2023 •

edited

Loading

nojb commented Dec 15, 2023 •

edited

Loading

nojb commented Dec 15, 2023 •

edited

Loading

nojb commented Dec 15, 2023 •

edited

Loading

nojb commented Dec 16, 2023 •

edited

Loading