favour odocls that are not dependencies #9956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
added
the
odoc
|
Looks correct to me. Just needs a rebase. |
jonludlam
approved these changes
Feb 13, 2024
|
Also, please DCO |
EmileTrotignon
force-pushed
the
odocl-favouritism
branch
from
da7bc81 to
feaa399
Compare
Signed-off-by: Emile Trotignon <[email protected]>
EmileTrotignon
force-pushed
the
odocl-favouritism
branch
from
feaa399 to
4c68cb6
Compare
Signed-off-by: Rudi Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling sherlodoc on with @doc-new, all the .odocl are indexed by sherlodoc. It makes sense to index the dependencies, but the entries from the dependencies should be given less priority as search results.
This PR passes a
--favouredflag to sherlodoc, this flag identifies the .odocls that are not external. In turn, sherlodoc ranks these entries higher.