Add MerlinLocateImpl, MerlinLocateIntf commands #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trefis
reviewed
Dec 1, 2020
| @@ -376,14 +376,34 @@ endfunction | |||
|
|
|||
| function! merlin#Locate(...) | |||
| if (a:0 > 1) | |||
| echoerr "Locate: to many arguments (expected 0 or 1)" | |||
| echoerr "Locate: too many arguments (expected 0 or 1)" | |||
| elseif (a:0 == 0) || (a:1 == "") | ||
| MerlinPy merlin.vim_locate_under_cursor() | ||
| else | ||
| MerlinPy merlin.vim_locate_at_cursor(vim.eval("a:1")) | ||
| endif | ||
| endfunction | ||
|
|
||
| function! merlin#LocateImpl(...) |
There was a problem hiding this comment.
Naïve question (because I haven't touched vimscript in years), why can't this function be implemented as:
let l:pref = g:merlin_locate_preference
let g:merlin_locate_preference = 'ml'
call merlin#Locate(...)
let g:merlin_locate_preference = l:prefThere was a problem hiding this comment.
Updated to do roughly this. Vimscript being vimscript, your elegant call syntax needed to be replaced with something much uglier and less obvious:
call call("merlin#Locate", a:000)
|
Pushed a small change to enable completion for the commands. |
|
Thanks! |
voodoos
pushed a commit
to voodoos/merlin
that referenced
this pull request
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added these as part of my debugging for #1202, but they have turned out to be generally useful and low-cost to add.
The commands behave as
MerlinLocate, but jumping to either the implementation or interface regardless of the contents ofg:merlin_locate_preference.