refactor-open: don't return useless edits

[ulugbekna]

Before this PR refactor-open returns edits that when applied do not change the document, e.g,

Calling unqualify on this:

open Unix 

let f = times () 

returned

{
  "class": "return",
  "value": [
    {
      "start": {
        "line": 2,
        "col": 16
      },
      "end": {
        "line": 2,
        "col": 21
      },
      "content": "times"
    }
  ],
...
}

This is a hacky solution though, which doesn't work for multi-line identifiers (which are rare in OCaml, I guess). A proper solution would involve changing Mbrowse.node_paths to return longidents along with paths. I would appreciate input on which way to go.

Notes:

• Based on refactor-open qualify uses short-paths #1313
• I'm sending these PRs separately since their goals are not interconnected (the commits are but that can be fixed easily)

[rgrinberg]

Ping @trefis or @voodoos. We'd like these fixes before including the feature in lsp

[trefis]

(I'll have a look at this next week)

[trefis]

I'll let you rebase and update the changelog entry before giving it one last look (and merging).

[ulugbekna]

@trefis this should be ready

…

On Tue, 6 Jul 2021 at 17:49, Thomas Refis ***@***.***> wrote: I'll let you rebase and update the changelog entry before giving it one last look (and merging). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1314 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4YR66DATICSPH6EL6I77DTWL3WDANCNFSM42W3ON4Q> .