Add special exception for extension failure #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. On the lsp side, I will simply turn this exception into a non fatal error and display it the message to the user. Thanks! |
|
@let-def is this ready to merge? |
let-def
force-pushed
the
extension-failure
branch
from
c54c332 to
08abc10
Compare
|
Done. |
|
Should this be ported to https://github.com/let-def/merlin-extend/ too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in ocamllabs/vscode-ocaml-platform#818.
@rgrinberg The exception constructor has path
Extend_main.Handshake.Error, is it ok? Anything else I can do to help vscode-ocaml-platform code?