Vendor directory fixes #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rudi Grinberg <[email protected]>
We need the ocaml lsp server to contain its own vendored directory. So that we only deleted those directories at build time. Signed-off-by: Rudi Grinberg <[email protected]>
|
@Gbury give it a try now. |
|
@rgrinberg I'm still getting the same error: It looks like the unvendor script is correctly removing the vendored directories, but |
|
Yeah, this seems like a dune subst bug that I will report upstream.
I disabled dune subst for lsp for now.
…On Oct 22, 2020, 12:19 AM -0700, Guillaume Bury ***@***.***>, wrote:
@rgrinberg I'm still getting the same error:
Error: ocaml-lsp-server/vendor/cmdliner: No such file or directory
It looks like the unvendor script is correctly removing the vendored directories, but dune subst tries and either fetch info or modify some things in these directories, and fail because they do not exist anymore.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #260
For now, there are two main changes:
unvendor.mlscriptThe installation of a pinned version now fails at
dune subst, with the error:However I don't know enough about dune to know how to fix that, ^^