Fix extracting path from URI #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
force-pushed
the
fix-uri-path-extract
branch
from
006f6d4 to
527d931
Compare
mnxn
approved these changes
Apr 26, 2021
|
I made the URI parsing a little better and removed the code that caused this bug altogether. |
rgrinberg
force-pushed
the
fix-uri-path-extract
branch
from
e377bd5 to
5ba613e
Compare
Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
force-pushed
the
fix-uri-path-extract
branch
from
5ba613e to
23e1708
Compare
|
I think there are too many slashes at the beginning now: Developer console: |
Signed-off-by: Rudi Grinberg <[email protected]>
|
@rgrinberg: I think there might be a problem with this patch too. My projects are filled with "Unbound module" errors and there are no errors/exception in the log or developer console. The first commit of this PR (527d931) had neither problem. |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
May 1, 2021
CHANGES: ## Features - Code action to annotate a value with its type (ocaml/ocaml-lsp#397) ## Fixes - Fix interface/implementation switching on Windows (ocaml/ocaml-lsp#427) - Correctly parse project paths with spaces and other special characters that must be escaped. - Print types with `-short-paths` even if the project wasn't built yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see if this works @mnxn