test(uri): add an e2e test for uri #771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatchi
commented
Jul 4, 2022
| `); | ||
| const params = await receivedDiganostics; | ||
|
|
||
| expect(params.uri).toBe(uri); |
There was a problem hiding this comment.
It fails with:
Expected: "file:///src/n%C3%A9w/M%C3%B6del%20%2B%20Other%20Th%C3%AEng%C3%9F/test.ml"
Received: "file:///src/n%C3%A9w/M%C3%B6del %2B Other Th%C3%AEng%C3%9F/test.ml"#739 should fix it but I'm not sure if we really need an e2e test for that since we already have OCaml tests for the URI parsing?
Signed-off-by: Rudi Grinberg <[email protected]> ps-id: ff9fc51c-ce4b-4c1d-852a-2a86c4b7d4aa
tatchi
commented
Jul 5, 2022
| in | ||
| let run = | ||
| let* (_ : InitializeResult.t) = Client.initialized client in | ||
| let uri = DocumentUri.of_path "src/néw/Mödel + Other Thîngß/test.ml" in |
There was a problem hiding this comment.
I don't think it represents what happens in reality because our DocumentUri.of_path implementation isn't correct so the URI string that will be sent to the server is already "broken".
What happens in real is that VSCode sends a valid URI string, and the server returns an incorrect one (due to an incorrect parsing).
There was a problem hiding this comment.
As I said, I'm not sure that an e2e test is useful for that. We already have unit tests for the URI parsing.
|
Please re-open if this still relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an e2e test to demonstrate that paths with special characters (space, accents, ...) are not well handled. I used a
DidOpenTextDocumentNotificationbut it doesn't matter, any request/notification that sends auriwill have the same issue.