Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] stdlib-shims (0.2.0) #15011

Closed
wants to merge 1 commit into from
Closed

[new release] stdlib-shims (0.2.0) #15011

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 8, 2019

Backport some of the new stdlib features to older compiler

CHANGES:

CHANGES:

- Fix compilation with OCaml >= 4.07 under msvc (@dra27, ocaml/stdlib-shims#12, fixes ocaml/stdlib-shims#11)
@camelus
Copy link
Contributor

camelus commented Oct 8, 2019

☀️ All lint checks passed 8be5523
  • These packages passed lint tests: stdlib-shims.0.2.0

☀️ Installability check (+1)
  • new installable packages (1): stdlib-shims.0.2.0

@kit-ty-kate
Copy link
Member

There is an error on OCaml 4.02:


#=== ERROR while compiling stdlib-shims.0.2.0 =================================#
# context              2.0.5 | linux/x86_64 | ocaml-base-compiler.4.02.3 | pinned(https://github.com/ocaml/stdlib-shims/releases/download/0.2.0/stdlib-shims-0.2.0.tbz)
# path                 ~/.opam/4.02/.opam-switch/build/stdlib-shims.0.2.0
# command              ~/.opam/4.02/bin/dune build -p stdlib-shims -j 2
# exit-code            1
# env-file             ~/.opam/log/stdlib-shims-23-7ff8c2.env
# output-file          ~/.opam/log/stdlib-shims-23-7ff8c2.out
### output ###
#     ocamldep src/.stdlib_shims.objs/float.ml.d (exit 2)
# (cd _build/default && /home/opam/.opam/4.02/bin/ocamldep.opt -modules -impl src/float.ml) > _build/default/src/.stdlib_shims.objs/float.ml.d
# File "src/float.ml", line 28, characters 13-16:
# Error: Syntax error

#=== ERROR while compiling stdlib-shims.0.2.0 =================================#
# context              2.0.5 | linux/x86_64 | ocaml-base-compiler.4.02.3 | pinned(https://github.com/ocaml/stdlib-shims/releases/download/0.2.0/stdlib-shims-0.2.0.tbz)
# path                 ~/.opam/4.02/.opam-switch/build/stdlib-shims.0.2.0
# command              ~/.opam/4.02/bin/dune build -p stdlib-shims -j 2
# exit-code            1
# env-file             ~/.opam/log/stdlib-shims-23-7ff8c2.env
# output-file          ~/.opam/log/stdlib-shims-23-7ff8c2.out
### output ###
#     ocamldep src/.stdlib_shims.objs/float.ml.d (exit 2)
# (cd _build/default && /home/opam/.opam/4.02/bin/ocamldep.opt -modules -impl src/float.ml) > _build/default/src/.stdlib_shims.objs/float.ml.d
# File "src/float.ml", line 28, characters 13-16:
# Error: Syntax error

@ghost
Copy link
Author

ghost commented Oct 9, 2019

@dra27 just pointed out that the sources are in a weird state. The upstream branches are a bit messed up and need a bit of love. We'll re-submit a release once it's sorted. Sorry for the noise!

@ghost ghost closed this Oct 9, 2019
@dra27 dra27 mentioned this pull request Nov 11, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build with OCaml 4.07.1 Win32
3 participants