[new release] ocaml-lsp-server, lsp and jsonrpc (1.2.0) #17641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: ## Features - Add keyword completion - Add go to declaration functionality to jump to a value's specification in a .mli file (ocaml/ocaml-lsp#294) ## Fixes - ocaml/ocaml-lsp#245: correctly use mutexes on OpenBSD (ocaml/ocaml-lsp#264) - ocaml/ocaml-lsp#268: Do not use vendored libraries when building the lsp package (ocaml/ocaml-lsp#260) - ocaml/ocaml-lsp#271: Clear diagnostics when files are closed - Disable non-prefix completion. There's no reliably way to trigger it and it can be slow.
|
Commit: 5b80671 A pull request by opam-seasoned @rgrinberg. ☀️ All lint checks passed 5b80671
☀️ Installability check (+3)
|
kit-ty-kate
reviewed
Nov 17, 2020
There was a problem hiding this comment.
jsonrpc seemed to miss some dependencies on OCaml < 4.08:
#=== ERROR while compiling jsonrpc.1.2.0 ======================================#
# context 2.0.7 | linux/x86_64 | ocaml-base-compiler.4.07.1 | pinned(https://github.com/ocaml/ocaml-lsp/releases/download/1.2.0/jsonrpc-1.2.0.tbz)
# path ~/.opam/4.07/.opam-switch/build/jsonrpc.1.2.0
# command ~/.opam/4.07/bin/dune build -p jsonrpc -j 72 @install
# exit-code 1
# env-file ~/.opam/log/jsonrpc-24-b14e2e.env
# output-file ~/.opam/log/jsonrpc-24-b14e2e.out
### output ###
# File "jsonrpc/src/dune", line 4, characters 13-26:
# 4 | (preprocess future_syntax))
# ^^^^^^^^^^^^^
# Error: Program ocaml-syntax-shims not found in the tree or in PATH
# (context: default)
I just fixed that.
Could the 3 fixes i've done be returned to the upstream opam files?
I'm just waiting for CI to check again, an answer for the question above and this should be good to go.
|
I'll push the fixes upstream shortly |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSP Server for OCaml
CHANGES:
Features
Add keyword completion
Add go to declaration functionality to jump to a value's specification in a
.mli file (Implement TextDocumentDeclaration ocaml-lsp#294)
Fixes
Crashes on FreeBSD with "Mutex.lock: Resource deadlock avoided" ocaml-lsp#245: correctly use mutexes on OpenBSD (Fix mutex change of ownership (OpenBSD) ocaml-lsp#264)
Conflict on uutf ocaml-lsp#268: Do not use vendored libraries when building the lsp package (delete vendor directory when installing lsp ocaml-lsp#260)
Clear diagnostics for non-project files ocaml-lsp#271: Clear diagnostics when files are closed
Disable non-prefix completion. There's no reliably way to trigger it and it
can be slow.