Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: uucd.14.0.0, uucp.14.0.0, uunf.14.0.0, uuseg.14.0.0 #19599

Merged

Conversation

dbuenzli
Copy link
Contributor

  • Add: uucd.14.0.0 home, doc, issues
    Unicode character database decoder for OCaml
  • Add: uucp.14.0.0 home, doc, issues
    Unicode character properties for OCaml
  • Add: uunf.14.0.0 home, doc, issues
    Unicode text normalization for OCaml
  • Add: uuseg.14.0.0 home, doc, issues
    Unicode text segmentation for OCaml

uucd v14.0.0 2021-09-17 Zagreb

  • Support for Unicode 14.0.0

uucp v14.0.0 2021-09-17 Zagreb

  • Unicode 14.0.0 support.
  • Tweak Uucp.Break.tty_width_hint (09d2186). Thanks to David Kaloper
    Meršinjak.

uunf v14.0.0 2021-09-17 Zagreb

  • Unicode 14.0.0 support.

uuseg v14.0.0 2021-09-17 Zagreb

  • Unicode 14.0.0 support.

Use b0 cmd -- .opam.publish uucd.14.0.0 uucp.14.0.0 uunf.14.0.0 uuseg.14.0.0 to update the pull request.

@dbuenzli
Copy link
Contributor Author

Some failures due to 404 rev deps. The others are due to stack limits. See dbuenzli/uunf#16 We looked with @kit-ty-kate but it seems a bit unclear on what exactly has to be done. A work around is to compile with ulimit -s unlimited.

@mseri
Copy link
Member

mseri commented Sep 17, 2021

Should we add a post-install failure message on ppc64 and aarch64 to say that? Something like "In case your build fails with "ocamlopt.opt got signal and exited", please retry the compilation with "ulimit -s unlimited".

@dbuenzli
Copy link
Contributor Author

Oh I think it's a good idea. @kit-ty-kate suggested to

build: [
  [<normal-build>] {arch != "ppc64"}
  ["sh" "-c" "ulimit -s unlimited && <normal-build>"] {arch = "ppc64"}
]

but I'm rather against these things since they make problem go under the radar. But having a message seems good.

@mseri
Copy link
Member

mseri commented Sep 17, 2021

Yeah, that is a nice hassle free solution, but honestly I prefer for it to fail informatively rather than do magic that I would prefer to have control over

@dbuenzli
Copy link
Contributor Author

Ok I'll look into that later this afternoon. If on the top of your head you have a package in mind where I can copycat the syntax from, welcome. Otherwise I'll dig into the manual.

@mseri
Copy link
Member

mseri commented Sep 17, 2021

Sure:

post-messages: [
"This package requires libpci-dev (>= 3.2.0) to be installed on your system" {failure & (os = "debian")}
"This package requires libpci-dev (>= 3.2.0) to be installed on your system" {failure & (os = "ubuntu")}
"This package requires pciutils-devel (>= 3.2.0) to be installed on your system" {failure & (os = "centos")}
]

post-messages: [
"A failure in the middle of the build may be caused by build parallelism
(enabled by default).
Please file a bug report at https://github.com/ocaml/opam-repository/issues"
{failure & jobs > 1 & os != "cygwin"}
"You can try installing again including --jobs=1
to force a sequential build instead."
{failure & jobs > 1 & os != "cygwin" & opam-version >= "2.0.5"}
]

post-messages: [ "On OPAM 2.1 this package may be not installable because CI uses more aggressive sandboxing. The issue is fixed in versions >= 0.7." { failure } ]

@dbuenzli dbuenzli force-pushed the b0-publish-uucd.14.0.0-etc-16498f30185818d3 branch from fdb4e8f to 58694d5 Compare September 17, 2021 12:15
@dbuenzli
Copy link
Contributor Author

dbuenzli commented Sep 17, 2021

The post messages where added in uunf and uucp.

@mseri
Copy link
Member

mseri commented Sep 17, 2021

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants