Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a post-message for num's known install failure #20645

Merged
merged 7 commits into from
Apr 7, 2022

Conversation

shonfeder
Copy link
Contributor

This is meant to help users workaround the known installation failure with num reported in #14646 (and the various linked issues).

The failure message was first suggested at #14646 (comment), and pointers to the configuration change needed was provided by @dbuenzli in a reply.

This PR is to propose the workaround, but I honestly don't know which versions it should be applied to or what the optimal messaging is here. All corrections and suggestions for improvement welcome.

Comment on lines 47 to 48
ocamlfind remove num
ocamlfind remove num-top
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a common issue why not run these before each install instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how frequent the problem is. It only hits me about once every couple of months. I'm happy with that tho, if it seems sensible! I'll wait until the additional reviewer you've tagged in weighs in :)

Thanks for the suggestion!

@kit-ty-kate kit-ty-kate requested a review from dra27 February 3, 2022 23:36
@dra27
Copy link
Member

dra27 commented Feb 4, 2022

The inclusion of a message looks fine - does this issue remain macOS-specific? Can you remind why it's ocamlfind remove rather than brew remove? I had thought the problem here was the system package manager's installed copy of num, which you wouldn't normally remove using ocamlfind itself?

@shonfeder
Copy link
Contributor Author

I hit this periodically on arch and Ubuntu, and afaik, have no installation of num other than via opam. I’m not clear on the underlying cause, unfortunately, and I am just cargo cutting the fix proposed in the linked issue :)

@mseri
Copy link
Member

mseri commented Feb 8, 2022

I hit the same bug both without homebrew and on linux in the past a few times, I think adding the comment is harmless and help people incurring in this in the future. Otherwise, as @kit-ty-kate suggested, let's run those commands anyway in the install step

@mseri mseri merged commit 03ab8c0 into ocaml:master Apr 7, 2022
@shonfeder shonfeder deleted the num-pkg-post-message branch April 7, 2022 13:59
@shonfeder
Copy link
Contributor Author

Thanks for the better fix! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants