[new release] ocaml-lsp-server, lsp and jsonrpc (1.10.0) #20718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: ## Features - Add better support for code folding: more folds and more precise folds ## Fixes - Fix infer interface code action crash when implementation source does not exist (ocaml/ocaml-lsp#597) - Improve error message when the reason plugin for merlin is absent (ocaml/ocaml-lsp#608) - Fix `chdir` races when running ppx (ocaml/ocaml-lsp#550) - More accurate completion kinds. New completion kinds for variants and fields. Removed inaccurate completion kinds for constructors and types. (ocaml/ocaml-lsp#510) - Fix handling request cancellation (ocaml/ocaml-lsp#616)
|
Was it always failing on centos7? |
|
I don't know but centos 7 is so old that I don't have much desire to investigate. Let's just mark it unavailable there. |
|
I don’t think we can make such a fine availability check, let’s merge as is. I think we can figure it out if somebody has issues with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSP Server for OCaml
CHANGES:
Features
Fixes
Fix infer interface code action crash when implementation source does not
exist (fix: crash when inferring interface ocaml-lsp#597)
Improve error message when the reason plugin for merlin is absent (fix: improve error messages when merlin is absent ocaml-lsp#608)
Fix
chdirraces when running ppx (Switch to a proper scheduler ocaml-lsp#550)More accurate completion kinds.
New completion kinds for variants and fields. Removed inaccurate completion
kinds for constructors and types. (Improve completion kinds ocaml-lsp#510)
Fix handling request cancellation (Fix cancel request param (de)serialization ocaml-lsp#616)