Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coq-of-ocaml: add version 2.5.3 #22839

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Conversation

clarus
Copy link
Contributor

@clarus clarus commented Jan 4, 2023

There are versions for OCaml 4.12, 4.13, and 4.14. Thanks!

[make "-C" "proofs" "install"] {coq:installed}
]
depends: [
"angstrom"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing a lower-bound for this constraint. This is causing the CI error:

# File "src/constant.ml", line 55, characters 13-25:
# 55 | let dquote = Angstrom.map ~f:(fun _ -> PDQuote) (Angstrom.char '"')
#                   ^^^^^^^^^^^^
# Error: Unbound value Angstrom.map

I think the map function was introduced in 0.15.0: inhabitedtype/angstrom@93f29c2

So I'd suggest

Suggested change
"angstrom"
"angstrom" {>= "0.15.0"}

If this is correct, then you should also upstream this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the same change is needed on all three package files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have added the constraint for all three packages.

]
depends: [
"angstrom" {>= "0.15.0"}
"csexp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a lower-bound constraint missing here:
lower-bounds (failed: Unbound type constructor Csexp.t)

I'm not sure what exact version you need, but the downgrade which reveals the error is:

downgrade csexp              1.5.1 to 1.0.0      [required by coq-of-ocaml]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks! I added a lower bound constraint.

@kit-ty-kate
Copy link
Member

Thanks

@kit-ty-kate kit-ty-kate merged commit 2642a3d into ocaml:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants