-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coq-of-ocaml: add version 2.5.3 #22839
Conversation
[make "-C" "proofs" "install"] {coq:installed} | ||
] | ||
depends: [ | ||
"angstrom" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing a lower-bound for this constraint. This is causing the CI error:
# File "src/constant.ml", line 55, characters 13-25:
# 55 | let dquote = Angstrom.map ~f:(fun _ -> PDQuote) (Angstrom.char '"')
# ^^^^^^^^^^^^
# Error: Unbound value Angstrom.map
I think the map
function was introduced in 0.15.0: inhabitedtype/angstrom@93f29c2
So I'd suggest
"angstrom" | |
"angstrom" {>= "0.15.0"} |
If this is correct, then you should also upstream this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the same change is needed on all three package files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have added the constraint for all three packages.
] | ||
depends: [ | ||
"angstrom" {>= "0.15.0"} | ||
"csexp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a lower-bound constraint missing here:
lower-bounds (failed: Unbound type constructor Csexp.t)
I'm not sure what exact version you need, but the downgrade which reveals the error is:
downgrade csexp 1.5.1 to 1.0.0 [required by coq-of-ocaml]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks! I added a lower bound constraint.
bbd6f89
to
a41ddac
Compare
Thanks |
There are versions for OCaml 4.12, 4.13, and 4.14. Thanks!