Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] macaddr, macaddr-sexp, macaddr-cstruct, ipaddr, ipaddr-sexp and ipaddr-cstruct (5.4.0) #23504

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

…sexp and ipaddr-cstruct (5.4.0)

CHANGES:

* Use Bytes.t for IPv6 addresses (mirage/ocaml-ipaddr#115 @verbosemode, fixes mirage/ocaml-ipaddr#16 @dsheets)
* Also fixes V6.to_int64 (reported by @RyanGibb in mirage/ocaml-ipaddr#113)
@hannesm
Copy link
Member Author

hannesm commented Mar 14, 2023

The CI failures are unrelated, good to merge.

Noteworthy are the mirage failures -- where the tests use opam-monorepo (which bundles opam), which fails since the runners use opam 2.2 now, while opam-monorepo still uses opam 2.1 - which refuese to touch metadata files of version 2.2:

# +  [ERROR] Refusing write access to /home/opam/.opam, which is more recent than this version of opam (2.2~alpha > 2.1), aborting.
# +  Fatal error: exception OpamStd.OpamSys.Exit(15)
# +  Raised at OpamStd.OpamSys.exit in file "duniverse/opam/src/core/opamStd.ml", line 1042, characters 15-29
# +  Called from OpamStateConfig.load_defaults in file "duniverse/opam/src/state/opamStateConfig.ml", line 352, characters 12-36
# +  Called from Dune__exe__Opam_monorepo.init_opam in file "bin/opam_monorepo.ml", line 24, characters 9-45
# +  Called from Dune__exe__Opam_monorepo in file "bin/opam_monorepo.ml", line 67, characters 2-14

@kit-ty-kate
Copy link
Member

Thanks

@kit-ty-kate kit-ty-kate merged commit f6fce75 into ocaml:master Mar 15, 2023
@hannesm hannesm deleted the release-ipaddr-v5.4.0 branch February 27, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use 16-byte string for internal representation of IPv6 addresses
2 participants