Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

higher-bound constraint on ocaml version for mdx packages #24467

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

raphael-proust
Copy link
Contributor

There have been some errors in the revdeps of the CI of some other packages pointing to mdx issues. This PR adds missing upper-bound constraints.

@kit-ty-kate
Copy link
Member

Example of such error:

# File "lib/top/mdx_top.ml", lines 217-220, characters 27-44:
# Warning 8 [partial-match]: this pattern-matching is not exhaustive.
# Here is an example of a case that is not matched:
# Pextra_ty (_, _)

Fixed upstream by realworldocaml/mdx#435

@mseri
Copy link
Member

mseri commented Sep 21, 2023

Thanks

@talex5
Copy link
Contributor

talex5 commented Sep 25, 2023

Marking MDX as incompatible with OCaml 5.1 means that projects using MDX are not getting much testing in ocaml-ci. For example, Eio is now only tested on one platform (debian-12-5.0_opam-2.1). All the other distributions and architectures try to test with 5.1, which is no longer available.

@mseri
Copy link
Member

mseri commented Sep 25, 2023

We need to push for a release of mdx with the fix. I have opened an issue on the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants