Add flexdll.0.35-flexdll.0.43 and winpthreads.20240209-1 #25512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installs the sources of flexdll for use by the compiler packages when building on Windows. These are all the releases of FlexDLL which can be used in "bootstrapping" mode with OCaml.
|
Obviously OCaml 5.3.0 is not yet even branched, but the winpthreads package is already needed for |
Installs the sources of winpthreads for use by the compiler packages when building MSVC OCaml 5.3+.
dra27
force-pushed
the
flexdll-winpthreads
branch
from
c532995 to
23c798c
Compare
How embarrassing, I only tested these packages on Windows 😉 It turns out the winpthreads package is Windows-specific, which I've updated it to reflect! |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This I think is the last prequisite before opening the "main" PR updating the compiler packages for Windows support.
Both of these packages provide sources needed in addition to the compiler's own sources when compiling on Windows. Windows OCaml has required FlexDLL since OCaml 3.11, but it had to be installed separately. Adding to the complexity, the main part of FlexDLL is written in OCaml. Since OCaml 4.03.0, it has been possible to build OCaml and FlexDLL simultaneously, but the compiler does not distribute the required sources, and those what this flexdll package provides (this required support in FlexDLL was first added in 0.35, which is the reason for the older releases going back no further - these are the only releases there can have ever been).
OCaml 5.3.0 will introduce a requirement for the MSVC ports of OCaml in a very similar way with the winpthreads library.
These packages simply install required sources to the
sharedirectory of the switch which are then picked up by theconfigurescript of OCaml (using it's--with-flexdlland--with-winpthreads-msvcoptions). The packages are not constrained to Windows as the opam packages aren't particularly Windows-specific (and, indeed, at some point cross-compilers will certain want the FlexDLL sources).flexdll 0.35-0.43 are already released, which is why they reference
flexdll.installfrom the master branch of the repository. When it's released, FlexDLL 0.44's tarball will include the .install file.