-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+lwt.3.0.0 - concurrency library #8929
Conversation
❗ opam-lint warnings 2d5d484
✅ Installability check (6502 → 6506)
|
Any ideas? Should I add a |
Ok, I see that |
cc @garrigue |
It might be useful to just create one PR with only the base Lwt package, to test revdeps for that in isolation. Then followup PRs that include Lwt and the optional new packages like Lwt_glib |
Thanks. I also thought to just add |
@aantron how feasible is it to move lwt.ppx to a separate ppx_lwt library to remove that dependency as well? it's very brittle with new compiler versions. |
It's certainly technically very feasible. It's probably wiser to port it to Actually, I don't think we've had a PPX breakage on my watch. Last one was in 4.03. Is it breaking in 4.06 or something? Or do you mean it's brittle because it takes time to adapt There is a related issue here: ocsigen/lwt#266 |
Closing in favor of #8956. I think it makes more sense to build up the history and fix dependencies there. |
Lwt 3.0.0 is finally here.
Changelog:
I originally wanted to estimate the failed revdeps from this locally. However, since I expect this to still fail the revdeps build at least once, I think it makes more sense to just let it run, and try to add the right constraints afterwards.
cc @mfp @c-cube