Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+lwt.3.0.0 - concurrency library #8929

Closed
wants to merge 1 commit into from
Closed

Conversation

aantron
Copy link
Contributor

@aantron aantron commented Apr 11, 2017

Lwt 3.0.0 is finally here.

Changelog:

Breaking

I originally wanted to estimate the failed revdeps from this locally. However, since I expect this to still fail the revdeps build at least once, I think it makes more sense to just let it run, and try to add the right constraints afterwards.

cc @mfp @c-cube

@camelus
Copy link
Contributor

camelus commented Apr 11, 2017

❗ opam-lint warnings 2d5d484
  • lwt.3.0.0 has some warnings:

    • warning 41: Some packages are mentionned in package scripts of features, but there is no dependency or depopt toward them: "lablgtk", "lwt_glib",
      "lwt_react", "lwt_ssl", "react", "ssl"
  • These packages passed lint tests: lwt_glib.1.0.1, lwt_react.1.0.1, lwt_ssl.1.0.1


✅ Installability check (6502 → 6506)
  • new installable packages (4): lwt.3.0.0 lwt_glib.1.0.1 lwt_react.1.0.1 lwt_ssl.1.0.1

@aantron
Copy link
Contributor Author

aantron commented Apr 11, 2017

lwt_glib is failing to build in CI due to missing external library glib (pkg-config name glib-2.0). I'm not sure how to add a dependency on it – there doesn't seem to be a conf- package for either gtk or glib. I'm not sure how it built in the past, either. lwt_glib used to have a dependency on lablgtk, but that package only has depopts, only on things like conf-gtksourceview. I can't find the logs from the previous builds in #8196, but I doubt conf-gtksourceview and the other depopts were installed, so I'm assuming that gtk was somehow present in the build containers anyway.

Any ideas? Should I add a conf-gtk and/or conf-glib package to OPAM?

@aantron
Copy link
Contributor Author

aantron commented Apr 11, 2017

Ok, I see that lablgtk has depexts built into it directly. Perhaps those should be factored out? lwt_glib doesn't need all of lablgtk, only the external dependencies.

@aantron
Copy link
Contributor Author

aantron commented Apr 11, 2017

cc @garrigue

@avsm
Copy link
Member

avsm commented Apr 11, 2017

It might be useful to just create one PR with only the base Lwt package, to test revdeps for that in isolation. Then followup PRs that include Lwt and the optional new packages like Lwt_glib

@aantron
Copy link
Contributor Author

aantron commented Apr 12, 2017

Thanks. I also thought to just add lablgtk temporarily to lwt_glib, but separate PRs is probably wiser. Base package is in above linked PR.

@avsm
Copy link
Member

avsm commented Apr 12, 2017

@aantron how feasible is it to move lwt.ppx to a separate ppx_lwt library to remove that dependency as well? it's very brittle with new compiler versions.

@aantron
Copy link
Contributor Author

aantron commented Apr 12, 2017

It's certainly technically very feasible. It's probably wiser to port it to ocaml-migrate-parsetree, though.

Actually, I don't think we've had a PPX breakage on my watch. Last one was in 4.03. Is it breaking in 4.06 or something? Or do you mean it's brittle because it takes time to adapt ppx_tools/ocaml-migrate-parsetree?

There is a related issue here: ocsigen/lwt#266

@aantron
Copy link
Contributor Author

aantron commented Apr 16, 2017

Closing in favor of #8956. I think it makes more sense to build up the history and fix dependencies there.

@aantron aantron closed this Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants