-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update header protocol for version 2.2.77 #38
Conversation
src/rpc/protocol/mod.rs
Outdated
+ 4 // original len | ||
; | ||
// version 227 | ||
pub const RPC_PACKET_HEADER_SIZE_WITH_NEWSERVER: usize = RPC_PACKET_HEADER_SIZE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the name here be consistent with the Java client? Also,
Comments containing "227" need to be removed, the latest observer also has those domains, and comments containing "227" will be confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will remove comment containing "227", and rename this const variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about comment version: V4
, refer to java client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After dealing with those comments, I will run your repo in my env, testing this client in 3.x observer. Please provide me a link to your repo.
https://github.com/MachaelLee/obkv-table-client-rs/tree/feat_bump_227 |
LGTM |
What changes were proposed in this pull request?
Why are the changes needed?
see #37
Will break the compatibility? How if so?
No, it is compatibility even I change the protocol header, I add some column
Does this PR introduce any user-facing change?
How was this patch tested?
Checklist