Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update header protocol for version 2.2.77 #38

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

MichaelLeeHZ
Copy link
Contributor

@MichaelLeeHZ MichaelLeeHZ commented Apr 19, 2023

What changes were proposed in this pull request?

  • Add some fields in ObRpcPacketHeader
  • Implement relevant encode and decode method

Why are the changes needed?

see #37

Will break the compatibility? How if so?

No, it is compatibility even I change the protocol header, I add some column

Does this PR introduce any user-facing change?

How was this patch tested?

Checklist

  • I've run the tests to see all new and existing tests pass.
  • If this Pull Request resolves an issue, I linked to the issue in the text above.
  • I've informed the technical writer about the documentation change if necessary.

@MichaelLeeHZ MichaelLeeHZ changed the title bug: update header protocol for version 227 fix: update header protocol for version 227 Apr 19, 2023
@MichaelLeeHZ MichaelLeeHZ changed the title fix: update header protocol for version 227 fix: update header protocol for version 2.2.77 Apr 19, 2023
+ 4 // original len
;
// version 227
pub const RPC_PACKET_HEADER_SIZE_WITH_NEWSERVER: usize = RPC_PACKET_HEADER_SIZE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the name here be consistent with the Java client? Also,
Comments containing "227" need to be removed, the latest observer also has those domains, and comments containing "227" will be confusing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will remove comment containing "227", and rename this const variable.

Copy link
Contributor Author

@MichaelLeeHZ MichaelLeeHZ Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about comment version: V4, refer to java client?

Copy link
Contributor

@IHEII IHEII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After dealing with those comments, I will run your repo in my env, testing this client in 3.x observer. Please provide me a link to your repo.

src/rpc/protocol/mod.rs Outdated Show resolved Hide resolved
src/rpc/protocol/mod.rs Show resolved Hide resolved
@MichaelLeeHZ
Copy link
Contributor Author

After dealing with those comments, I will run your repo in my env, testing this client in 3.x observer. Please provide me a link to your repo.

https://github.com/MachaelLee/obkv-table-client-rs/tree/feat_bump_227

@IHEII
Copy link
Contributor

IHEII commented Apr 19, 2023

LGTM
Pass all tests in observer 3.x.
Although there are some problems when there are multi-observers and set master of partition into a random observer, the issue has nothing to do this the MR.

@IHEII IHEII merged commit 4fe1271 into oceanbase:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants