Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(design): Tooltip closeIcon should consider visible prop #231

Merged
merged 1 commit into from
Oct 29, 2023
Merged

fix(design): Tooltip closeIcon should consider visible prop #231

merged 1 commit into from
Oct 29, 2023

Conversation

dengfuping
Copy link
Collaborator

@dengfuping dengfuping commented Oct 29, 2023 •
edited
Loading

Before After
2023-10-29 17-00-24 2023-10-29 17_01_18 2023-10-29 16-57-00 2023-10-29 16_58_10

Tests

  • close icon should work correctly for open
  • close icon should work correctly for visible

@github-actions
Copy link

github-actions bot commented Oct 29, 2023 •
edited
Loading

@dengfuping dengfuping merged commit 928a436 into master Oct 29, 2023
5 checks passed
@dengfuping dengfuping mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix @oceanbase/design Tooltip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dengfuping