Use fancy_regex instead of onig #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
commented
Dec 6, 2019
| }; | ||
|
|
||
| let model: Option<String> = | ||
| if let Some(model_replacement) = &self.model_replacement { | ||
| none_if_empty(replace(&model_replacement, &captures)) | ||
| } else { | ||
| captures.at(3).map(str::to_string) | ||
| captures | ||
| .get(1) |
There was a problem hiding this comment.
This behavior was ported from the official Python implementation and is necessary for making the tests pass. I have read the "specification" document of uap-core and I have no idea what the intended behavior is or why this used to work before.
This was referenced Dec 6, 2019
|
Thanks for the PR! It's really appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on fancy-regex/fancy-regex#38
We want this because we experienced multiple onig segfaults during our testing.