Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fileinfo for arweave file #672

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Fix fileinfo for arweave file #672

merged 3 commits into from
Nov 16, 2023

Conversation

mariacarmina
Copy link
Member

Fixes # .

Changes proposed in this PR:

  • Added check for file path validation inside UrlFile class.
  • Fix fileinfo for arweave file.
  • Updated tests.

@mariacarmina mariacarmina self-assigned this Nov 16, 2023
alexcos20
alexcos20 requested changes Nov 16, 2023
View reviewed changes
ocean_provider/file_types/definitions.py Outdated Show resolved Hide resolved
ocean_provider/file_types/definitions.py Outdated Show resolved Hide resolved
alexcos20
alexcos20 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mariacarmina mariacarmina merged commit 3958799 into main Nov 16, 2023
@mariacarmina mariacarmina deleted the fix-fileinfo-for-arweave branch November 16, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 alexcos20 approved these changes

Assignees

@mariacarmina mariacarmina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariacarmina @alexcos20