Add extra documentation for the journalEntryRealtime field #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I love this sort of documentation. |
chris-martin
requested changes
Aug 16, 2023
TristanCacqueray
force-pushed
the
master
branch
from
08466ce to
14bae6b
Compare
This change documents how to convert the journalEntryRealtime field to an UTCTime and notes that there is a better JournalFields.
TristanCacqueray
force-pushed
the
master
branch
from
14bae6b to
0f467b9
Compare
|
Alright, so it will cost an extra dependency on time, and I've tested this still works locally. |
I think I like it though, we already depend on it transitively anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change documents how to convert the journalEntryRealtime field
to an UTCTime and notes that there is a better JournalFields.