Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

chore: exclude utility folders from being loaded as commands #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peterjah
Copy link

@peterjah peterjah commented Jan 10, 2020

excludes all __*__ folders from sub command parser

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #95 into master will decrease coverage by 66.81%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #95       +/-   ##
========================================
- Coverage   66.81%    0%   -66.82%     
========================================
  Files           7     2        -5     
  Lines         452    12      -440     
  Branches      127     3      -124     
========================================
- Hits          302     0      -302     
+ Misses        101    12       -89     
+ Partials       49     0       -49
Impacted Files Coverage Δ
src/index.ts 0% <0%> (-100%) ⬇️
src/debug.ts 0% <0%> (-45.46%) ⬇️
src/ts-node.ts
src/util.ts
src/config.ts
src/command.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c6c78...486f541. Read the comment docs.

@peterjah peterjah changed the title chore: exclude folders from being loaded as commands chore: exclude utility folders from being loaded as commands Jan 13, 2020
@RasPhilCo
Copy link
Contributor

RasPhilCo commented Jun 9, 2020

Curious, I haven't seen this convention used in node (python, yes), what are you storing in the utils that you'd rather not store outside the commands dir?

@peterjah
Copy link
Author

peterjah commented Jul 8, 2020

The __*__ syntax is also used in typescript (for the test folder __tests__ ) , but it could be something else... I am using utility files common to a group of commands. And my files outsides commands dir are mixed together which can be quite messy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants