fix: fixed done callbacks

oclif · Jan 26, 2018 · 5ef8df8 · 5ef8df8
1 parent a5c73b0
commit 5ef8df8
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/src/base.ts b/src/base.ts
@@ -53,7 +53,10 @@ const base = <I extends Types.Context>(context: I): Types.Base<I, {}> => {
       }
       if (context.error) throw context.error
     }
-    return context.test(arg1, (cb && cb.length === 2) ? done => run(done) : () => run())
+    function runWithDone(done: MochaDone) {
+      run(done).catch(done)
+    }
+    return context.test(arg1, (cb && cb.length === 2) ? runWithDone : () => run())
   }
   return {
     ...Object.entries(context.plugins)

diff --git a/src/types.ts b/src/types.ts
@@ -26,8 +26,8 @@ export interface PluginDef {
 export interface Plugins {[k: string]: PluginDef}
 
 export interface It<I> {
-  (expectation: string, cb?: (context: I, done?: MochaDone) => any): void
-  (cb?: (context: I, done?: MochaDone) => any): void
+  (expectation: string, cb?: (context: I, done: MochaDone) => any): void
+  (cb?: (context: I, done: MochaDone) => any): void
 }
 
 export type Base<I extends Context, T extends Plugins> = {

diff --git a/test/finally.test.ts b/test/finally.test.ts
@@ -15,3 +15,19 @@ describe('finally', () => {
   .finally(() => {})
   .it('finally')
 })
+
+describe('done', () => {
+  // fancy
+  // .do(() => {throw new Error('x')})
+  // .it('calls done', (_, done) => {
+  //   done('foo')
+  // })
+  // fancy
+  // .it('calls done', (_, done) => {
+  //   done('foo')
+  // })
+  fancy
+  .it('calls done', (_, done) => {
+    done()
+  })
+})