Cleanup imports in common.py, lstm.py, extract exceptions #154
Conversation
kba
commented
Nov 15, 2016
kba
commented
- Move exceptions to its own module
- Make all imports explicit, so static code analysis tools like pyflakes can help
- remove redundant deprecated decorators
- Remove old load_components
- Remove old draw_pseg/draw_aligned
They haven't been in use for a while and not working currently
Neither is used and there is another implementation in toplevel.py
Obsolete now and won't work with current codebase
| import cPickle | ||
| from ocrolib.exceptions import (BadClassLabel, BadInput, FileNotFound, |
There was a problem hiding this comment.
Should move down to third block (first-party imports).
| import pylab | ||
| from pylab import imshow | ||
| from scipy.ndimage import morphology,measurements | ||
| from pylab import (clf, cm, ginput, gray, imshow, ion, subplot, where) |
There was a problem hiding this comment.
I've got a branch that removes pylab imports; should I open a PR for that?
There was a problem hiding this comment.
You mean https://github.com/QuLogic/ocropy/commits/standard-import? Sure, open a PR with the pertinent commits, looks really helpful, I'll happily merge/cherry-pick.
There was a problem hiding this comment.
Yes, that's the one; though I just noticed that it's based on the Python 3 work, so it'll be a pain to cherry-pick. Should get that in ASAP and then the rest would be easier.
|
|
||
| import numpy | ||
| from numpy import * | ||
| from numpy import (amax, amin, array, bitwise_and, clip, dtype, mean, minimum, | ||
| nan, ndarray, sin, sqrt, zeros) |
There was a problem hiding this comment.
The branch also standardizes these imports too...
(See below comment.)
| import PIL | ||
|
|
||
| from default import getlocal | ||
| from toplevel import * | ||
| from toplevel import (checks, ABINARY2, AINT2, AINT3, BOOL, DARKSEG, GRAYSCALE, | ||
| LIGHTSEG, LINESEG, PAGESEG) | ||
| import chars | ||
| import codecs | ||
| import ligatures | ||
| import lstm | ||
| import morph | ||
| import multiprocessing |
There was a problem hiding this comment.
Should move up to first block (standard library imports).
|
I see that the exceptions are deleted in |
kba
changed the title
