-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete unused lru.py #273
Delete unused lru.py #273
Conversation
This one we could actually delete, since it's just a copy of the snippet from http://code.activestate.com/recipes/498245-lru-and-lfu-cache-decorators/. |
First, I wanted to delete completely, but then I saw that there is code in |
About the OLD dir. Maybe it should be removed. Git keeps the history, you know... |
'ocropus-sauvola' might be useful. See #210. Consider moving it back to the root dir. It could be used as an alternative to 'ocropus-nlbin'. |
That's true but while you can find/retrieve old files in Git if you know how and what to look for, discovering useful deleted code is tedious (e.g. when searching in Github or Google). I do agree that we should prune all the really old stuff not usable anymore but some code like the sauvola implementation or the synthetic training code is still useful to have for study. @amitdo Feel free to open a PR for the ocropus-sauvola so we can test/adapt it to the current state of code base. @zuphilip I would really delete lru.py. |
You can solve this issue by creating a new 'ocropy-unused' repo and move most of the stuff in 'OLD' dir to this repo. |
lru.py was a copy of the python recipe from http://code.activestate.com/recipes/498245-lru-and-lfu-cache-decorators/
e1cceb1
to
04347dc
Compare
Okay, the file is deleted now. @kba ready to merge? |
No description provided.