Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lwt_unix.bind should be in the monad #230

Closed
dsheets opened this issue Apr 11, 2016 · 1 comment
Closed

Lwt_unix.bind should be in the monad #230

dsheets opened this issue Apr 11, 2016 · 1 comment
Labels
breaking
Milestone
2.7.0

Comments

@dsheets
Copy link
Contributor

dsheets commented Apr 11, 2016 

Lwt_unix.(bind sock (ADDR_UNIX sock_path)) : unit

could block indefinitely due to FS mknod on sock_path.
@aantron
Copy link
Collaborator

aantron commented Apr 29, 2016

Agreed. Seems like it would have to wait for a major release though, unless there is some way to change this gracefully without breaking existing code, and still end up with the name bind.

@aantron aantron mentioned this issue Oct 2, 2016
Closed
This was referenced Nov 21, 2016
Closed
Merged
@aantron aantron modified the milestone: 2.7.0 Nov 28, 2016
@aantron aantron mentioned this issue Jan 3, 2017
Closed
aantron added a commit that referenced this issue Apr 8, 2017
@aantron
Breaking: switch to non-blocking Lwt_unix.bind
431355a 
Originally requested in #230 and prepared in #296.
aantron added a commit that referenced this issue Apr 9, 2017
@aantron
Breaking: switch to non-blocking Lwt_unix.bind
242b0ff 
Originally requested in #230 and prepared in #296.
aantron added a commit that referenced this issue Apr 10, 2017
@aantron
Breaking: switch to non-blocking Lwt_unix.bind
f0793d8 
Originally requested in #230 and prepared in #296.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
2 participants
@dsheets @aantron