Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete simple-top #371

Closed
aantron opened this issue May 22, 2017 · 1 comment
Closed

Delete simple-top #371

aantron opened this issue May 22, 2017 · 1 comment
Labels
breaking
Milestone
4.0.0

Comments

@aantron
Copy link
Collaborator

aantron commented May 22, 2017

simple-top was deprecated in favor of utop in or before bb73e98 (summer 2011). There are no users in OPAM. A GitHub search for it returns only @bobzhang's ocaml-book and @kkirstein's proglang-playground.

I think we can announce the removal of simple-top in the next minor release, and delete it 4.0.0.

Related #313.
@aantron aantron added this to the 3.1.0 milestone May 22, 2017
@kkirstein
Copy link

That's fine with me, just kick it out as planned...

@aantron aantron mentioned this issue Jun 25, 2017
Merged
@aantron aantron modified the milestones: 3.1.0, 4.0.0 Jul 18, 2017
This was referenced Jul 18, 2017
Closed
Merged
Closed
@aantron aantron mentioned this issue Nov 6, 2017
Closed
aantron added a commit that referenced this issue Dec 23, 2017
@aantron
Delete lwt.simple-top
9e9cf45 
Resolves #371.

The changes to discover.ml done in #313 are left in place, because I am
not sure if we still want to pass the -custom flag.
@aantron aantron mentioned this issue Dec 23, 2017
Merged
aantron added a commit that referenced this issue Mar 24, 2018
@aantron
Delete lwt.simple-top
abcb270 
Resolves #371.

The changes to discover.ml done in #313 are left in place, because I am
not sure if we still want to pass the -custom flag.
aantron added a commit that referenced this issue Mar 24, 2018
@aantron
Delete lwt.simple-top
320d16c 
Resolves #371.

The changes to discover.ml done in #313 are left in place, because I am
not sure if we still want to pass the -custom flag.
@aantron aantron mentioned this issue Mar 30, 2018
Merged
@aantron aantron mentioned this issue Aug 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@kkirstein @aantron