Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPX: remove -no-debug option #528

Closed
aantron opened this issue Dec 26, 2017 · 1 comment
Closed

PPX: remove -no-debug option #528

aantron opened this issue Dec 26, 2017 · 1 comment
Milestone

Comments

@aantron
Copy link
Collaborator

aantron commented Dec 26, 2017

The -no-debug option disables PPX backtrace support (which is currently broken anyway).

In opam, -no-debug is used only by sqlexpr.

I've never heard of any complaints that backtrace support is too slow. On the contrary, everyone wants backtrace support to be restored and improved in Lwt.

I propose we make -no-debug do nothing, simplify the PPX code, and remove the option entirely in some far future version of Lwt.

@kandu
Copy link
Contributor

kandu commented Dec 28, 2017

-no-debug ease my life when hacking lwt.ppx, the generated code is mush shorter so that the generated parsetree is acceptable to be parsed by my own eyes. 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants