-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to jbuilder #374
Closed
Closed
Port to jbuilder #374
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
dbb4963
almost working ppx for jbuilder; just cant get linkall to apply...
andrewray 0fa50d2
magic cmxs ocamlbuild rule courtest @jdimino
andrewray 68b161f
1st pass at jbuilder
andrewray 30b8a80
add configurator dep
andrewray de3d931
opinionated reorganisation of packages
andrewray 291f605
add lwt.ppx to lwt. notes on a few bad package builds
andrewray e721933
add parsing of ocamlc -config to discover.ml
andrewray a988946
rename syntax to camlp4. Add -p to opam test commands
andrewray a384933
missed a syntax->camlp4 conversion in META
andrewray 2da8764
add proper configuration for glib
andrewray e9f0907
add flag detection for lwt-unix
andrewray 512d277
new package lwt-xxx, map to old name lwt.xxx
andrewray e13bac7
remove old build system
andrewray 7b6d9d0
add synopsis fields
andrewray 94383e4
use exists_if in lwt META to only shadow installed packages
andrewray b28726b
note build problems on 4.03
andrewray b825120
Refact libraries to match current lwt configuration
andrewray d99fb6d
Remove dependancy on Base and Stdio
andrewray 6c1705f
fix ppx so it builds on 4.02..04
andrewray ffffdea
fixup opam files and test across a few ocaml versions
andrewray a926624
Fix top-level configuration
andrewray 3b29534
fix lwt.opam typo
andrewray 49d909a
fix error message in discover.ml
andrewray cd1e12c
add workspace file. works with current jbuilder master
andrewray 5a044c6
have a go at updating the travis script
andrewray a17ec27
try to fix travis script (part 2 of many...)
andrewray c13e28a
try to fix appveyor
andrewray 20a979d
try to fix appveyor script
andrewray 358f333
set os_type correctly in discover.ml
andrewray 4973a51
and finally link with ws2_32 library
andrewray 353f501
for appveryor, run the tests through opam instead.
andrewray b9ff5dc
add jbuilder odoc target, disable 4.05 on travis
andrewray 890ccc2
print each tests to see whats failing on travis
andrewray d827388
add makefile for wikidoc and ocamldoc generation
andrewray ef6021c
jenkins documentation build
andrewray b120197
install uchar and ocamlbuild deps for jenkins
andrewray ddc6330
address jbuilder code review issues
andrewray b0551ea
work around for camlp4 issue.
andrewray 67a34ac
add configuration check to makefile
andrewray 455fe57
didn't mean to remove the install target from the Makefile
andrewray c075a63
Fix up lwt_react, lwt_ssl, lwt_glib opam files
aantron dacbef8
Fix up lwt.opam
aantron 0a33c49
Revert change to README.md
aantron 7ca76aa
More fixing up of lwt_react, lwt_ssl, lwt_glib
aantron e0077c3
Nits: remove some trailing whitespace
aantron 9fb2f5d
One last trailing whitespace nit!
aantron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,14 @@ | ||
_build | ||
src/unix/lwt_config.ml | ||
src/unix/lwt_config.h | ||
src/unix/lwt_unix_jobs_generated.ml | ||
src/unix/jobs-unix/ | ||
setup.data | ||
setup.log | ||
setup.exe | ||
setup-dev.exe | ||
_opam | ||
src/unix/lwt_config | ||
src/jbuild-ignore | ||
|
||
# Coverage analysis. | ||
bisect*.out | ||
_coverage/ | ||
|
||
# For local work, tests, etc. | ||
scratch/ | ||
|
||
# Autogenerated by jbuider | ||
.merlin | ||
*.install |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,134 @@ | ||
# | ||
# This file has been copied from _build/default/META.lwt then | ||
# modified to add exists_if clauses to support optional | ||
# compilation and the camlp4 syntax extension packages have | ||
# been given appropriate predicates. | ||
# | ||
|
||
version = "dev" | ||
description = "Monadic promises and concurrent I/O" | ||
requires = "bytes result" | ||
archive(byte) = "lwt.cma" | ||
archive(native) = "lwt.cmxa" | ||
plugin(byte) = "lwt.cma" | ||
plugin(native) = "lwt.cmxs" | ||
package "log" ( | ||
directory = "log" | ||
version = "dev" | ||
description = "Logger for Lwt" | ||
requires = "bytes lwt result" | ||
archive(byte) = "lwt_log.cma" | ||
archive(native) = "lwt_log.cmxa" | ||
plugin(byte) = "lwt_log.cma" | ||
plugin(native) = "lwt_log.cmxs" | ||
exists_if = "lwt_log.cma" | ||
) | ||
package "ppx" ( | ||
directory = "ppx" | ||
version = "dev" | ||
description = "Lwt PPX syntax extension" | ||
requires(ppx_driver) = "compiler-libs | ||
compiler-libs.common | ||
ocaml-migrate-parsetree | ||
ppx_tools_versioned" | ||
archive(ppx_driver,byte) = "ppx_lwt.cma" | ||
archive(ppx_driver,native) = "ppx_lwt.cmxa" | ||
plugin(ppx_driver,byte) = "ppx_lwt.cma" | ||
plugin(ppx_driver,native) = "ppx_lwt.cmxs" | ||
exists_if = "ppx_lwt.cma" | ||
# This is what jbuilder uses to find out the runtime dependencies of | ||
# a preprocessor | ||
ppx_runtime_deps = "bytes lwt result" | ||
# This line makes things transparent for people mixing preprocessors | ||
# and normal dependencies | ||
requires(-ppx_driver) = "lwt.ppx.deprecated-ppx-method" | ||
package "deprecated-ppx-method" ( | ||
version = "dev" | ||
description = "glue package for the deprecated method of using ppx" | ||
requires = "bytes lwt result" | ||
ppx(-ppx_driver,-custom_ppx) = "./ppx.exe --as-ppx" | ||
exists_if = "ppx_lwt.cma" | ||
) | ||
) | ||
package "preemptive" ( | ||
directory = "preemptive" | ||
version = "dev" | ||
description = "Preemptive thread support for Lwt" | ||
requires = "bigarray | ||
bytes | ||
lwt | ||
lwt.log | ||
lwt.unix | ||
result | ||
threads | ||
threads.posix | ||
unix" | ||
archive(byte) = "lwt_preemptive.cma" | ||
archive(native) = "lwt_preemptive.cmxa" | ||
plugin(byte) = "lwt_preemptive.cma" | ||
plugin(native) = "lwt_preemptive.cmxs" | ||
exists_if = "lwt_preemptive.cma" | ||
) | ||
package "simple-top" ( | ||
directory = "simple-top" | ||
version = "dev" | ||
description = "Lwt-OCaml top level integration (deprecated; use utop)" | ||
requires = "bigarray | ||
bytes | ||
compiler-libs | ||
compiler-libs.common | ||
lwt | ||
lwt.log | ||
lwt.unix | ||
result | ||
unix" | ||
archive(byte) = "lwt_simple_top.cma" | ||
archive(native) = "lwt_simple_top.cmxa" | ||
plugin(byte) = "lwt_simple_top.cma" | ||
plugin(native) = "lwt_simple_top.cmxs" | ||
exists_if = "lwt_simple_top.cma" | ||
) | ||
package "syntax" ( | ||
directory = "syntax" | ||
version = "dev" | ||
description = "Camlp4 syntax for Lwt (deprecated; use lwt.ppx)" | ||
requires = "camlp4 lwt.syntax.options" | ||
archive(syntax, preprocessor) = "lwt_syntax.cma" | ||
archive(syntax, toploop) = "lwt_syntax.cma" | ||
archive(syntax, preprocessor, native) = "lwt_syntax.cmxa" | ||
archive(syntax, preprocessor, native, plugin) = "lwt_syntax.cmxs" | ||
exists_if = "lwt_syntax.cma" | ||
package "log" ( | ||
directory = "log" | ||
version = "dev" | ||
description = "Camlp4 syntax for Lwt logging (deprecated; use lwt.ppx)" | ||
requires = "camlp4 lwt.syntax.options" | ||
archive(syntax, preprocessor) = "lwt_syntax_log.cma" | ||
archive(syntax, toploop) = "lwt_syntax_log.cma" | ||
archive(syntax, preprocessor, native) = "lwt_syntax_log.cmxa" | ||
archive(syntax, preprocessor, native, plugin) = "lwt_syntax_log.cmxs" | ||
exists_if = "lwt_syntax_log.cma" | ||
) | ||
package "options" ( | ||
directory = "options" | ||
version = "dev" | ||
description = "Options for Lwt Camlp4 syntax extension (deprecated; use lwt.ppx)" | ||
requires = "camlp4" | ||
archive(syntax, preprocessor) = "lwt_syntax_options.cma" | ||
archive(syntax, toploop) = "lwt_syntax_options.cma" | ||
archive(syntax, preprocessor, native) = "lwt_syntax_options.cmxa" | ||
archive(syntax, preprocessor, native, plugin) = "lwt_syntax_options.cmxs" | ||
exists_if = "lwt_syntax_options.cma" | ||
) | ||
) | ||
package "unix" ( | ||
directory = "unix" | ||
version = "dev" | ||
description = "Unix support for Lwt" | ||
requires = "bigarray bytes lwt lwt.log result unix" | ||
archive(byte) = "lwt_unix.cma" | ||
archive(native) = "lwt_unix.cmxa" | ||
plugin(byte) = "lwt_unix.cma" | ||
plugin(native) = "lwt_unix.cmxs" | ||
exists_if = "lwt_unix.cma" | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find any discussion in the jbuilder repo about 4.05. Do you or anyone have a link? This doesn't block the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the bug may actually be related to a problem with 4.05+beta3, and it will work with 4.05+trunk